Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Author struct missing username #172

Closed
mattdee123 opened this issue Jan 12, 2024 · 1 comment
Closed

Author struct missing username #172

mattdee123 opened this issue Jan 12, 2024 · 1 comment
Assignees
Labels

Comments

@mattdee123
Copy link

Describe the bug
The build Author struct only contains a name and email. However, in a build.finished webhook, I see it also having a username field. It would be nice to have that in the struct as well to help when unmarshalling webhook events.

"author": {
  "name": "Matthew Dee",
  "username": "mdee",
  "email": "[redacted]"
},
@mattdee123 mattdee123 added the bug label Jan 12, 2024
@james2791
Copy link
Contributor

james2791 commented Jan 14, 2024

Hey @mattdee123 👋

Thanks for raising this with us - and I believe what we should be potentially altering is the build finished webhook event (specifically the typed buildEvent). The Author of the CreateBuild type you linked to is specifically used for REST API build#create, but also for build#get (which would return an Author model with the #get that looks like this)

I think we could potentially wrap this up under the struct literal ticket that was previously asked on (convert and also introduce specific types)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants