Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/valid-pipelines: trigger.yml does not seem to be valid #131

Open
rogpeppe opened this issue Dec 17, 2024 · 0 comments
Open

test/valid-pipelines: trigger.yml does not seem to be valid #131

rogpeppe opened this issue Dec 17, 2024 · 0 comments

Comments

@rogpeppe
Copy link
Contributor

As of commit 2fbbfc1

The trigger.yml test does not seem to be valid against the schema.

Specifically the last two steps in that test instance data:

  - trigger: "a-slug"
    soft_fail:
      - exit_status: 1

  - trigger: "a-slug"
    soft_fail:
      - exit_status: "*"

have a value for soft_fail that is not compatible with the soft_fail field for triggerStep as defined in the schema, which only allows boolean-like atoms.

Perhaps it might be worth enabling CI gating on these tests passing?
FWIW I'm not sure whether it's the schema or the instance data that's at fault here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant