You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now pkg/registry/fetch.go is in a bit of a weird place - it abstracts away the actual fetching of the image to an interface and doesn't interact with the other components of the same package.
I ran into this when I wanted to import a CNB-related constant into the registry fetcher, it fell into an import cycle of pkg/registry -> pkg/cnb -> pkg/dockercreds -> pkg/registry. Maybe I could've created a pkg/cnb/consts package for all the constants, but I feel that registry.Fetcher has fundamentally different uses than registry.Client, registry.KeychainFactory, and registry.Resolver.
The text was updated successfully, but these errors were encountered:
Right now
pkg/registry/fetch.go
is in a bit of a weird place - it abstracts away the actual fetching of the image to an interface and doesn't interact with the other components of the same package.I ran into this when I wanted to import a CNB-related constant into the registry fetcher, it fell into an import cycle of
pkg/registry
->pkg/cnb
->pkg/dockercreds
->pkg/registry
. Maybe I could've created apkg/cnb/consts
package for all the constants, but I feel thatregistry.Fetcher
has fundamentally different uses thanregistry.Client
,registry.KeychainFactory
, andregistry.Resolver
.The text was updated successfully, but these errors were encountered: