Bug Report - Incorrect Series Indexing in trend.py (Line 1030)

[Donotavio]

Description

There is an issue in the _run method of the trend.py file of the ta package where the self._psar Series is accessed incorrectly.

Most of the indexing operations use .iloc[i], but at line 1030, the code uses self._psar[i] instead of self._psar.iloc[i], which can lead to unintended behavior.

Code Reference

The problematic line in trend.py:

if high2 > self._psar.iloc[i]:
    self._psar[i] = high2  # Incorrect indexing
elif high1 > self._psar.iloc[i]:
    self._psar.iloc[i] = high1

The first assignment should use .iloc[i] instead of direct indexing (self._psar[i]).

Steps to Reproduce

1. Run a script that calculates the Parabolic SAR (PSAR) indicator using the library.
2. If self._psar is a Pandas Series, attempting to access it via self._psar[i] instead of self._psar.iloc[i] can cause index mismatches or errors.
3. This can lead to unexpected results or performance issues.

Expected Behavior

The indexing should be done consistently throughout the _run method using .iloc[i].

Proposed Fix

Modify line 1030 of trend.py from:

self._psar[i] = high2  # Incorrect

to:

self._psar.iloc[i] = high2  # Correct

Environment

• ta version: (Specify the version you are using)
• Python version: (e.g., 3.9)
• Pandas version: (e.g., 1.5.3)
• OS: (Windows/Linux/macOS)

Additional Context

This change aligns with how indexing is handled in other parts of the _run method and ensures consistency when accessing Pandas Series.