Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons on buttons have inconsistent spacing #912

Open
kvnfrederiksen opened this issue Feb 14, 2019 · 1 comment
Open

Icons on buttons have inconsistent spacing #912

kvnfrederiksen opened this issue Feb 14, 2019 · 1 comment
Labels
requires discussion This issues needs to be reviewed before development can start

Comments

@kvnfrederiksen
Copy link
Contributor

Note: for support questions, please use one of these channels: Chat: BullhornOSS Gitter

Describe the bug
There is inconsistent spacing concerning the icons on the buttons.

To Reproduce
Steps to reproduce the behavior:

  1. Open this link: http://bullhorn.github.io/novo-elements/#/components/buttons
  2. Clearly view that the spacing on the icons, in relation to the text, is inconsistent (affected buttons are circled in the screenshot below)

inconsistentbuttons

Expected behavior
Icon and text should be centered to scale
@charlesabarnes charlesabarnes added requires discussion This issues needs to be reviewed before development can start and removed requires discussion This issues needs to be reviewed before development can start labels Mar 25, 2019
@charlesabarnes
Copy link
Contributor

Looks like this line could be causing the visual offcenterness?
https://github.com/bullhorn/novo-elements/blob/master/projects/novo-elements/src/styles/content/typography.scss#L156

@michael-amaya-bh michael-amaya-bh added requires discussion This issues needs to be reviewed before development can start and removed Needs UX Review labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
requires discussion This issues needs to be reviewed before development can start
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@charlesabarnes @MichaelDill @kvnfrederiksen @michael-amaya-bh