Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Raise SPI_IRQ_OUTPUT IRQ in SPI slave mode #298

Closed
wants to merge 2 commits into from

Conversation

aznoohwee
Copy link

@aznoohwee aznoohwee commented Jul 9, 2018

For #296 and #222, raise IRQ when firmware is operating as a SPI slave.

Nice to haves to make this PR more complete:

  • Unit test for SPI slave
  • Check status of !SS line
  • Only raise master IRQ if SPIE is enabled

@buserror
Copy link
Owner

Could you please rebase so there are no reverted comments? I suggest git rebase -i -- and squash stuff that is relevant together

@aznoohwee
Copy link
Author

Thanks and done!

@aznoohwee aznoohwee changed the title Raise SPI_IRQ_OUTPUT IRQ in SPI slave mode WIP: Raise SPI_IRQ_OUTPUT IRQ in SPI slave mode Jul 12, 2018
@aznoohwee
Copy link
Author

Placing a hold on PR. This is not quite the correct behavior. SPI ISR should be raised when data is received from master, not on slave register write.

@aznoohwee
Copy link
Author

unit test written and module checks out. no need to change, but leaving PR open if you want to include test.

@aznoohwee aznoohwee closed this Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants