Put MemoryPool and MmapMemory mmaps behind Arc #9682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In upcoming work we're going to centralize memory management inside `Mmap`. In order to do that, we need memory that logically borrows from the `Mmap` to have access to it. That turns out to be possible in some situations but very difficult in others (see bytecodealliance#9681 for an attempt that was a real hassle to get working). To prepare for this work, start moving these uses to be behind `Arc`. These aren't cloned at the moment, but they will be in the future.
sunshowers
commented
Nov 26, 2024
| /// reference. Making the callback `'static` goes some way towards ensuring | ||
| /// that, but it's still possible to squirrel away a reference into global | ||
| /// state. So don't do that. | ||
| unsafe fn with_slice_mut( |
There was a problem hiding this comment.
This was somewhat annoying but I think this approach makes sense -- basically ensure that any &mut references are very short-lived as required by Rust's aliasing rules.
github-actions
bot
added
the
wasmtime:api
|
I think this can make sense but I'm having a hard time understanding the end goal without the second piece here of using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In upcoming work we're going to centralize memory management inside
Mmap. In order to do that, we need memory that logically borrows from theMmapto have access to it. That turns out to be possible to do by passing in&Mmapin some situations but very difficult in others (see #9681 for an attempt that was a real hassle to get working and still had a bunch of incomplete questions within it).To prepare for this work, start moving these uses to be behind
Arc. These aren't cloned at the moment, but they will be in the future.