Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform a security audit to this library #5

Open
c0dearm opened this issue Jan 22, 2020 · 4 comments
Open

Perform a security audit to this library #5

c0dearm opened this issue Jan 22, 2020 · 4 comments
Labels
good first issue Good for newcomers

Comments

@c0dearm
Copy link
Owner

c0dearm commented Jan 22, 2020

I would like help from the community to run a serious security audit around this library and write issues about possible vulnerabilities

@c0dearm c0dearm added the good first issue Good for newcomers label Jan 22, 2020
@c0dearm c0dearm pinned this issue Jan 22, 2020
@librelois
Copy link

After studying the source code it seems to me that you do not deal with this problem:

https://en.wikipedia.org/wiki/Shamir's_Secret_Sharing#Problem

Maybe there's something I didn't understand. Are you treating this problem? And if so how?

@c0dearm
Copy link
Owner Author

c0dearm commented Feb 20, 2021

Hi @librelois, thanks for you input.

We deal with this problem by using finite field arithmetic, like the solution proposed in the link you shared.

More concretely, we use the Galois Field of characteristic 2 and dimension 8. This a good tradeoff because it makes it difficult to gain information for the reasons stated in the link and at the same time is computationally efficient because it allows to implement the algorithm using binary operations.

@librelois
Copy link

librelois commented Feb 20, 2021

Indeed I had focused only on the math module and I thought that the additions and multiplications were done like on a classical u8.
I just saw in the field module that it's not, thank you for your answer :)

@RyanSquared
Copy link

Howdy, an organization I'm affiliated with has paid for a security audit of a project that uses sharks, and I have some information I'd like to disclose. Would you mind reaching out to me? I can be reached at [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants