Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify templates: refactor EligibilityStart.eligibility_item_template #2759

Closed
angela-tran opened this issue Mar 18, 2025 · 0 comments · Fixed by #2774
Closed

Simplify templates: refactor EligibilityStart.eligibility_item_template #2759

angela-tran opened this issue Mar 18, 2025 · 0 comments · Fixed by #2774
Assignees
@thekaveman
Labels
back-end Django views, sessions, middleware, models, migrations etc. chore Chores and tasks for code cleanup, dev experience, etc. front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework
Milestone
Simplify templates

Comments

@angela-tran
Copy link
Member

Maybe we can take a follow-up item to refactor this field away from using these templates, and to encode the item strings directly in context.

Originally posted by @thekaveman in #2726 (comment)
@angela-tran angela-tran mentioned this issue Mar 18, 2025
Merged
@angela-tran angela-tran added this to the Simplify templates milestone Mar 18, 2025
@angela-tran angela-tran changed the title Refactor EligibilityStart.eligibility_item_template into context approach Simplify templates: refactor EligibilityStart.eligibility_item_template Mar 18, 2025
@thekaveman thekaveman moved this from Todo to Stretch in Digital Services Mar 18, 2025
@thekaveman thekaveman moved this from Stretch to Todo in Digital Services Mar 18, 2025
@thekaveman thekaveman self-assigned this Mar 20, 2025
@thekaveman thekaveman moved this from Todo to In progress in Digital Services Mar 20, 2025
@thekaveman thekaveman added chore Chores and tasks for code cleanup, dev experience, etc. front-end HTML/CSS/JavaScript and Django templates back-end Django views, sessions, middleware, models, migrations etc. i18n Copy: Language files or Django i18n framework labels Mar 20, 2025
@thekaveman thekaveman mentioned this issue Mar 20, 2025
Merged
@thekaveman thekaveman moved this from In progress to In review in Digital Services Mar 20, 2025
@github-project-automation github-project-automation bot moved this from In review to Done in Digital Services Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thekaveman thekaveman

Labels
back-end Django views, sessions, middleware, models, migrations etc. chore Chores and tasks for code cleanup, dev experience, etc. front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework
Projects
Digital Services
Status: Done
Milestone
Simplify templates
Development

Successfully merging a pull request may close this issue.

Refactor: remove eligibility item templates cal-itp/benefits
2 participants
@thekaveman @angela-tran