Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace TextChar types with traits #47

Open
caleb-allen opened this issue May 23, 2023 · 0 comments
Open

Replace TextChar types with traits #47

caleb-allen opened this issue May 23, 2023 · 0 comments

Comments

@caleb-allen
Copy link
Owner

caleb-allen commented May 23, 2023

The TextUtils submodule defines TextChar, whose subtypes are wrappers around Char. The types themselves aren't really necessary, and it might offer clarity to refactor the many junction_type methods to use traits rather than these TextChar subtypes

abstract type TextChar end

The package WhereTraits.jl may be a good fit here. I haven't looked under the hood so I don't know how it affects performance; my main concern is that it will hamper performance, but it may not be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant