Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add callbacks for active and inactive #5

Open
callmenick opened this issue Feb 20, 2016 · 2 comments
Open

Add callbacks for active and inactive #5

callmenick opened this issue Feb 20, 2016 · 2 comments
Labels
enhancement

Comments

@callmenick
Copy link
Owner

A lot of people want to use this to toggle menus. A good idea would be to re-think the component JavaScript to have event callbacks that users can plug in to.
@Hlsgs
Copy link

Hlsgs commented Aug 8, 2016 •
edited
Loading

+1
Also, i would move(and rename?) the .is-active class to the body or html tag as it's almost a give that the icon's state will affect outside elements.
Thanks for this, by the way!

@Kedarnath-Rothe
Copy link

Please assign this issue to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@callmenick @Hlsgs @Kedarnath-Rothe