Scaling is a bit off

[CelticMinstrel]

I don't know what's happening exactly, but elements are positioned a little bit differently when you set a higher scaling factor. One particularly notable example is the Force Default Party option in the scenario editor preferences – at a scale of 2, it overlaps the 3 LED. At a scale of 3 it's pushed even further down, overlapping the Cancel and OK buttons. I've only noticed it in dialogs so I don't think it affects the main window. I wonder if it could be that relative positioning is not accounting for scale somehow?

[NQNStudios]

separate bug, fixed now

Because I've just discovered that implicitly calling recalcRect() on controls in setText() causes a lot of problems. Every frame drifts a little in relative positioning, and when you page back and forth in a stack you get the frames warping more and more every time:

It seemed like a good idea, and I don't know what you were fixing in your branch when you changed that, but for my branch I'm just going to comment that out for now.

[CelticMinstrel]

The rect needs to be recalculated for the pattern name labels. I think that was the reason I made that change, and I made it general because (as you say) it seemed like a good idea. The alternative would have been to make racalcRect public so it can be called directly by the pattern picker.