Skip to content

Saving, relaunching, and reloading clears Curse #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NQNStudios opened this issue Apr 5, 2025 · 4 comments
Open

Saving, relaunching, and reloading clears Curse #710

NQNStudios opened this issue Apr 5, 2025 · 4 comments
Assignees
Labels
bug game Affects the game, as opposed to the editors

Comments

@NQNStudios
Copy link
Collaborator

NQNStudios commented Apr 5, 2025

Encountered while testing VoDT. Steps to reproduce

  • Checkout the first new commit on branch NQNStudios/2.0b1-c (which is not yet a PR)

  • Run this replay: VoDT_05-04-2025_14-32-10.xml.zip

    • Without 2.0b1-c, it will end with the game crashing and no fatal error message (because it's a segfault, I think).
  • When the replay ends without crashing, note that the whole party is cursed.

  • Save As and store the save file.

  • (required) Quit and relaunch Blades of Exile

  • Load the save file.

  • Note that no one is cursed.

@NQNStudios NQNStudios added bug game Affects the game, as opposed to the editors labels Apr 5, 2025
@NQNStudios NQNStudios changed the title Saving and reloading clears Curse Saving, relaunching, and reloading clears Curse Apr 5, 2025
@NQNStudios
Copy link
Collaborator Author

NQNStudios commented Apr 5, 2025

Related to this: If you play the replay, and immediately load a different file that's in a scenario, the party will be cursed in that file.

@NQNStudios
Copy link
Collaborator Author

NQNStudios commented Apr 5, 2025

For the first case, the status gets written out to pc{n}.txt correctly. After you load it in a fresh game session, and save again, pc{n}.txt will not have the status encoded in it. So it must be a flaw in extractSparse() which happens here.

@NQNStudios
Copy link
Collaborator Author

I want to make sure monsters save/reload their statuses too when this is fixed.

@NQNStudios NQNStudios self-assigned this Apr 5, 2025
NQNStudios added a commit to NQNStudios/cboe that referenced this issue Apr 5, 2025
@NQNStudios
Copy link
Collaborator Author

Fixed by 877e6d2 which will come in the 3rd beta 1 PR.

NQNStudios added a commit to NQNStudios/cboe that referenced this issue Apr 10, 2025
NQNStudios added a commit to NQNStudios/cboe that referenced this issue Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug game Affects the game, as opposed to the editors
Projects
None yet
Development

No branches or pull requests

1 participant