Skip to content

Should pacifists have non-pacifist spells grayed out in casting dialog? #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
NQNStudios opened this issue Apr 6, 2025 · 2 comments
Open

Should pacifists have non-pacifist spells grayed out in casting dialog? #711

NQNStudios opened this issue Apr 6, 2025 · 2 comments
Labels
enhancement game Affects the game, as opposed to the editors question

Comments

@NQNStudios
Copy link
Collaborator

Right now a pacifist can select non-pacifist spells in the casting dialog and get a buffer message saying they couldn't do it. Would it be better to just gray those spells out in the spell choice dialog?
@NQNStudios NQNStudios added enhancement game Affects the game, as opposed to the editors question labels Apr 6, 2025
@NQNStudios
Copy link
Collaborator Author

I think we would just change this function:

https://github.com/NQNStudios/cboe/blob/f22ba95563b98e792f51275a0b1c91b4fbd9b7e3/src/game/boe.party.cpp#L1548

@CelticMinstrel
Copy link
Member

This definitely seems like a reasonable thing to do.

NQNStudios added a commit to NQNStudios/cboe that referenced this issue Apr 6, 2025
@NQNStudios
pacifist gray LEDs for spells that harm. Fix calref#711
9191275
NQNStudios added a commit to NQNStudios/cboe that referenced this issue Apr 7, 2025
@NQNStudios
pacifist gray LEDs for spells that harm. Fix calref#711
af7fb2c
NQNStudios added a commit to NQNStudios/cboe that referenced this issue Apr 10, 2025
@NQNStudios
pacifist gray LEDs for spells that harm. Fix calref#711
fa1eaa2
NQNStudios added a commit to NQNStudios/cboe that referenced this issue Apr 10, 2025
@NQNStudios
pacifist gray LEDs for spells that harm. Fix calref#711
3f8ac36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement game Affects the game, as opposed to the editors question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CelticMinstrel @NQNStudios