Skip to content

Unidentified bolts don't show charges #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NQNStudios opened this issue Apr 9, 2025 · 1 comment
Open

Unidentified bolts don't show charges #718

NQNStudios opened this issue Apr 9, 2025 · 1 comment
Labels
bug game Affects the game, as opposed to the editors

Comments

@NQNStudios
Copy link
Collaborator

I'm guessing that charges are intentionally not shown for unidentified magical objects, which makes sense (unless it's a scroll, but I just checked and Scroll of Flame doesn't stack so I'm extrapolating that no scrolls do).

This behavior doesn't make sense for ammunition, though. Unidentified bolts should show their charge number because it's a plainly visible quantity, not a mysterious attribute.

Hopefully this can be fixed without having to add any XML flags. Maybe the presence of the missile-type flag is enough to distinguish an item that should hide charges and one that shouldn't?

@NQNStudios NQNStudios added bug game Affects the game, as opposed to the editors labels Apr 9, 2025
@NQNStudios
Copy link
Collaborator Author

Ok, here's where it happens: https://github.com/NQNStudios/cboe/blob/7339abee84c125051896eceb933e47aec203a1c3/src/game/boe.text.cpp#L329

Due to the existence of infinite-ammo missiles like the Sling, there is more complexity here than just checking if a missile-type is present. Maybe missile != 0 && max_charges != 0 would do the trick.

NQNStudios added a commit to NQNStudios/cboe that referenced this issue Apr 9, 2025
NQNStudios added a commit to NQNStudios/cboe that referenced this issue Apr 10, 2025
NQNStudios added a commit to NQNStudios/cboe that referenced this issue Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug game Affects the game, as opposed to the editors
Projects
None yet
Development

No branches or pull requests

1 participant