Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpstan.excludeFiles option does not exclude files #5

Open
jca opened this issue Jun 29, 2018 · 5 comments
Open

phpstan.excludeFiles option does not exclude files #5

jca opened this issue Jun 29, 2018 · 5 comments

Comments

@jca
Copy link

jca commented Jun 29, 2018

Files/folders added either to "files.exclude" and "phpstan.excludeFiles" should be excluded from phpstan checks as well, but it is not the case for me. The folders are already excluded in "files.exclude" successfully, but errors pop-up from the extension, even when the phpstan.excludeFiles option is set.

// Example workspace settings
{
	"folders": [
		{
			"path": "/Users/admin/Workspaces/myproject"
		}
	],
	"settings": {
		"phpstan.excludeFiles": [
			"mixedvendor",
			"mixedvendor/",
			"mixedvendor/*",
			"/mixedvendor",
			"/mixedvendor/",
			"/mixedvendor/*",
			"**/mixedvendor",
			"**/mixedvendor/",
			"**/mixedvendor/*",
		],
	},
}

This is happens MAC OSX

@calvinbaart
Copy link
Owner

Should be fixed in v0.1.8

@jca
Copy link
Author

jca commented Jul 9, 2018

Thanks Calvin for looking into it, but the bug is still present for me in v0.1.8
VS Code version v1.24.11
Running on Mac OS High Sierra

@calvinbaart calvinbaart reopened this Jul 10, 2018
@calvinbaart
Copy link
Owner

Reopened, I'll look into this. Does the excludeFiles option not work when opening the ignored file or when scanning the whole directory (PHPStan Scan of Errors command)?

@jca
Copy link
Author

jca commented Jul 10, 2018

Sorry, this morning I can't execute phpstan on my host system (Mac OSX) and I don't have the time to fix this unrelated issue.
When phpstan worked, the error showed directly in the "problems" bottom tab. The parent folder in the filesystem tab was shown in red.

@binarious
Copy link
Contributor

Any news? Still having this issue with the latest version.

"phpstan.excludeFiles": ["*Test.php"]

Problems are shown when the file is being saved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants