Release 1.1 (Release candidate) #21
Conversation
PedroDiez
added
documentation
There was a problem hiding this comment.
CHANGELOG.md and README.md are LGTM, just minor suggestions.
I looked also over the PR for the API definition, API Readiness Checklist and test definitions, and left my comments there.
Please ping me again, when these PRs are merged, so that I can finalize the release PR review.
CHANGELOG.md
Outdated
| * Generate API Readiness Checklist in https://github.com/camaraproject/CustomerInsights/pull/20 | ||
| * Generate `CHANGELOG.md` in https://github.com/camaraproject/CustomerInsights/pull/21 | ||
|
|
||
| ### Changed | ||
| * Including CodeOwners and Maintainers in https://github.com/camaraproject/CustomerInsights/pull/7 | ||
| * Update `README.md` mailing list and meeting minutes link in https://github.com/camaraproject/CustomerInsights/pull/6 | ||
| * Update `README.md` with meeting information in https://github.com/camaraproject/CustomerInsights/pull/13 |
There was a problem hiding this comment.
These "repository management" PR don't need to be listed, as they are not relevant to people who want to know what changed in the API. For this new API it would be enough to mention the first three points under "Added".
|
|
||
| The API definition(s) are based on | ||
| * Commonalities v0.5.0-rc.1 | ||
| * Identity and Consent Management v0.3.0-alpha.1 |
There was a problem hiding this comment.
ICM r2.2 is also (almost) available. If you have chance take the latest wording for the "# Authorization and authentication section"
Thanks for the review Herbert, I will ping you once the rest PRs are merged so as I will also be able to adapt "version" in API yaml. In the meantime, i will update based on your commnets |
Co-authored-by: Herbert Damker <[email protected]>
Co-authored-by: Herbert Damker <[email protected]>
Co-authored-by: Herbert Damker <[email protected]>
What type of PR is this?
What this PR does / why we need it:
Release 1.1 (Release candidate) PR for Customer Insights within Spring25 MetaRelease (M3)
Which issue(s) this PR fixes:
Fixes #3
Fixes #9
Fixes #11
Fixes #16
Fixes #17
Fixes #18
Special notes for reviewers:
The following PRs MUST be merged prior to this one:
Changelog input
Additional documentation
This section can be blank.