Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

startedAt y expiredAt do not follow date-time format #281

Closed
jlurien opened this issue Apr 11, 2024 · 4 comments
Closed

startedAt y expiredAt do not follow date-time format #281

jlurien opened this issue Apr 11, 2024 · 4 comments
Labels
Fall24 Relevant for maintenance of Fall24 release

Comments

@jlurien
Copy link
Collaborator

jlurien commented Apr 11, 2024

Problem description
Currently the properties in SesssionInfo startedAt and expiresAt are defined as "in seconds since Unix epoch", but this is very excepcional in CAMARA as all other time properties have format date-time, following RFC 3339.

Commonalities do not explicitly mandate to follow date-time format for time values, only to add reference to RFC 3339 if used, but it may require some more explicit guideline for this.

Expected behavior

Is this intentional or should we adopt date-time as well, which is more friendly for humans.

@eric-murray
Copy link
Collaborator

Happy to move to date-time format, but would like seconds to continue to be constrained to an integer, as fractional seconds would be excessive precision for this use case.

@hdamker hdamker added the Fall24 Relevant for maintenance of Fall24 release label Apr 19, 2024
@hdamker
Copy link
Collaborator

hdamker commented Apr 21, 2024

QoD Call on April 19th: Agreed to be done in scope of v0.11.0.

@tanjadegroot
Copy link

the common data types from commonalities has StartDate and EndDate types of type date-time, so I think the both name and type of the schema(s) in qod should be aligned to the common ones. Other types may also need to be checked.
btw the DeviceStatus has a similar schema called "startsAt" that also should be aligned to common schema.

@hdamker
Copy link
Collaborator

hdamker commented Jun 14, 2024

Fixed in #296

@hdamker hdamker closed this as completed Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fall24 Relevant for maintenance of Fall24 release
Projects
None yet
Development

No branches or pull requests

4 participants