Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct example in qod-provisioning-createProvisioning.feature #394

Closed
jlurien opened this issue Jan 10, 2025 · 2 comments
Closed

Correct example in qod-provisioning-createProvisioning.feature #394

jlurien opened this issue Jan 10, 2025 · 2 comments
Assignees
Labels
correction correction in documentation or alignment with commonalities Spring25 Issue in scope of Spring25 meta-release cycle

Comments

@jlurien
Copy link
Collaborator

jlurien commented Jan 10, 2025

Problem description
schemas and identifier types are misaligned in:

    @qod_provisioning_createProvisioning_400.5_device_identifiers_not_schema_compliant
...
        Examples:
            | device_identifier          | oas_spec_schema                             |
            | $.device.phoneNumber       | /components/schemas/PhoneNumber             |
            | $.device.ipv4Address       | /components/schemas/NetworkAccessIdentifier |
            | $.device.ipv6Address       | /components/schemas/DeviceIpv4Addr          |
            | $.device.networkIdentifier | /components/schemas/DeviceIpv6Address       |

Expected behavior
Fix the examples table

Double check that other similar test scenarios are fine

@jlurien jlurien added correction correction in documentation or alignment with commonalities Spring25 Issue in scope of Spring25 meta-release cycle labels Jan 10, 2025
@jlurien jlurien self-assigned this Jan 10, 2025
@eric-murray
Copy link
Collaborator

I fixed the examples as part of PR #391, as I was editing the files anyway and couldn't resist doing it

@hdamker
Copy link
Collaborator

hdamker commented Jan 21, 2025

Fixed with #391

@hdamker hdamker closed this as completed Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correction correction in documentation or alignment with commonalities Spring25 Issue in scope of Spring25 meta-release cycle
Projects
None yet
Development

No branches or pull requests

3 participants