fix(config): Update the as_dict method in ChatGPTConfig to set tool_choice to NOT_GIVEN #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hoice to NOT_GIVEN
Wendong-Fan
reviewed
Feb 18, 2025
There was a problem hiding this comment.
thanks @coolbeevip ! this issue has been fixed in #1424, feel free to check!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the compatibility of parameter validation when using the vllm OAI interface. Currently, if the
toolsparameter is not provided andtool_choiceis null, the API will throw aBadRequestError. The error message indicates that tools must be set when usingtool_choice.Fixes #1585
Checklist
Go over all the following points, and put an
xin all the boxes that apply.Fixes #issue-numberin the PR description (required)pyproject.tomlandpoetry.lockIf you are unsure about any of these, don't hesitate to ask. We are here to help!