New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React.cloneElement cause the filled component unmount and mount again #41

Open

horizon0514 opened this issue Jan 20, 2022 · 1 comment

horizon0514 commented Jan 20, 2022

https://github.com/camwest/react-slot-fill/blob/master/src/lib/components/Slot.ts#L102

aggElements.push(
     React.cloneElement(child, { key: index.toString() + index2.toString(), ...fillChildProps2 })
 );

The text was updated successfully, but these errors were encountered:

Author

horizon0514 commented Jan 20, 2022

I delete the cloneElement

aggElements.push(child);

and it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment