Remove work_dir argument from ProviderService methods

[mattculler]

Bug Description

The ProviderService class's __init__ takes a work_dir argument, stored as self._work_dir. Some ProviderService methods use this, but others take their own work_dir and use that instead. This situation is confusing at best, a source of potential bugs at worst.

Ideally, all work_dir arguments to methods can be removed and replaced with self._work_dir. If some method(s) actually do need a different work dir, perhaps the argument should be named something different? Or if it truly should be called work_dir and methods need to take their own, comment(s) illuminating the situation should be added.

This same situation doesn't exist on other service classes.

To Reproduce

vi craft_application/services/provider.py

[syncronize-issues-to-jira]

Thank you for reporting your feedback to us!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-3899.

This message was autogenerated

[lengau]

Could not reproduce.

(craft-application) lengau@ratel:~/Work/Code/craft-application$ vi craft_application/services/provider.py
Could not find command-not-found database. Run 'sudo apt update' to populate it.
vi: command not found