Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use src/default-custom-images.json in knative charms #247

Open
misohu opened this issue Nov 28, 2024 · 1 comment
Open

Use src/default-custom-images.json in knative charms #247

misohu opened this issue Nov 28, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@misohu
Copy link
Member

misohu commented Nov 28, 2024

Context

To specify rocks as default custom images for charms we use a pattern in other charms where we specify file src/default-custom-images.json with default image values. Kserve example. We want to apply same pattern for knative charms.

What needs to get done

  1. Create src/default-custom-images.json
  2. Use default image values from src/default-custom-images.json. Similar to this.
  3. Implement all necessary charm logic.

Definition of Done

  1. src/default-custom-images.json is created for all knative charms
  2. custom-images logic is implemented in the hooks.
@misohu misohu added the enhancement New feature or request label Nov 28, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-6598.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant