-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACL logs with MicroOVN do not work because of hard coded file path #12836
Comments
@escabo the Was this tested only using a microovn installation or also with a normal Ubuntu based OVN setup (such as the one described here https://documentation.ubuntu.com/lxd/en/latest/howto/network_ovn_setup/#set-up-a-standalone-ovn-network)? If it works with the standard OVN setup and not with the microovn setup then its likely an issue with the snap packaging in LXD not setting up the correct symlinks internally for the microovn log directory. |
This was with MicroOVN (in a MicroCloud setup) and I reported it because when I added symlinks, the error message disappeared. |
@masnax want to take a look at this one given you've done the work around microovn content interfaces previously? |
I think LXD and MicroOVN snaps should have a plug/interface to allow for easy retrieval of OVN logs by LXD. On the MicroOVN side, all I could find is for local log files. We currently have a couple of interfaces/connections between the 2:
I think an eventual This would be a joint effort with the MicroOVN team. |
Heres one for you @gabrielmougard |
After looking at it, it seems a bit complex... Since canonical/microovn#94, the OVN controller logs are directly sent to syslogs inside the MicroOVN snap. I don't think using a snap content interface would be ideal in this situation: since each snap has its own Instead, couldn't we just add the I think we'd also need a plug in MicroOVN (I like Then, inside LXD:
This solution is non-invasive for MicroOVN (litteraly just adding a dummy 'ovn-logs' plug to trigger the connect hook on the LXD side) However, the @tomponline @simondeziel how does it sound? (Having an |
what would be involved with getting microovn to log to the the LXD syslog listener, as per lxd/doc/howto/network_ovn_setup.md Line 181 in 5386396
|
@masnax does the microovn interface expose any unix sockets to the ovn DBs btw? |
We can't really update the OVN controller parameters from outside the snap (unlike setting |
The proposed solution from above would require three interactions:
|
Can we update the microovn snap to take an option to send logs to a different unix socket using |
I don't know if the OVN controller can directly output its logs to a UNIX socket. If this is possible, then we could share this socket (which would be LXD's |
It can, see https://documentation.ubuntu.com/lxd/en/latest/howto/network_ovn_setup/#send-ovn-logs-to-lxd |
What do you mean? |
If I understood correctly the snap architecture, each snap has its own |
Plus, this solves half the problem: we still don't have |
@gabrielmougard think we need a meeting about this as im not following you. |
Just the openvswitch socket. NB/SB/controller sockets are not exposed. |
Ack. But at least it shows that one can expose sockets over interfaces, which is what I was wondering. Thanks |
OK so after a quick discussion on MM @gabrielmougard and I are considering this approach:
|
Required information
Issue description
lxc network acl show-log bla
command always produces this error:Error: Only OVN log entries may be retrieved at this time
Seems like this line https://github.com/canonical/lxd/blob/main/lxd/network/acl/driver_common.go#L754 should be snap aware as if I manually create a link on the servers of the cluster to the snap location of the file (when using MicroOVN), the error disappears.
The text was updated successfully, but these errors were encountered: