Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to shell completions for lxc network|storage|config get|set|unset #14560

Closed
kadinsayani opened this issue Nov 29, 2024 · 1 comment · Fixed by #14894
Closed

Improvements to shell completions for lxc network|storage|config get|set|unset #14560

kadinsayani opened this issue Nov 29, 2024 · 1 comment · Fixed by #14894
Assignees
Labels
Improvement Improve to current situation
Milestone

Comments

@kadinsayani
Copy link
Contributor

kadinsayani commented Nov 29, 2024

  • lxc network|storage set|get should show configurable options;
  • lxc network|storage unset should show options that can be unset;
  • lxc config set|get should show configurable options based on scope;
  • lxc config unset should show options that can be unset based on scope.

Completion functions should use the new scope field in the metadata configuration API to contextually source applicable options.

@kadinsayani kadinsayani added the Improvement Improve to current situation label Nov 29, 2024
@kadinsayani kadinsayani added this to the lxd-6.3 milestone Nov 29, 2024
@kadinsayani kadinsayani self-assigned this Nov 29, 2024
@kadinsayani kadinsayani changed the title Improvements to shell completions for lxc network|storage get|set|unset Improvements to shell completions for lxc network|storage|config get|set|unset Nov 29, 2024
@kadinsayani
Copy link
Contributor Author

From the LXD docs:

When you configure an option with global scope on any cluster member, the changes are propagated to the other cluster members through the distributed database. The locally scoped options are set only on the cluster member where you configure them, unless you use the --target flag to specify a different cluster member.

Therefore, we don't want to contextually provide completions for server configuration options based on cluster member roles.

Furthermore:

In addition to the server configuration, there are cluster member configuration options that are specific to each cluster member.

We already have completions for getting and unsetting cluster member configuration options by way of the cmpClusterMemberConfigs function, so we just need to add completions for setting cluster member configuration options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Improve to current situation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant