Add Pure Storage storage driver #14599
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return err | ||
| } | ||
|
|
||
| err = os.Remove(mountPath) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
There was a problem hiding this comment.
I believe @simondeziel is planning to address this issue more generally higher up the call stack, so wont block this PR.
MusicDin
force-pushed
the
feat/pure-driver
branch
2 times, most recently
from
c53014e to
69f6cae
Compare
doc/howto/storage_pools.md
Outdated
|
|
||
| Create a storage pool named `pool1` that uses NVMe/TCP by default: | ||
|
|
||
| lxc storage create pool1 pure pure.gateway=https://<purestorage-address> pure.api.token=<purestorage-api-token> pure.array.address=<nvme-ip> |
There was a problem hiding this comment.
That gateway HTTPS verification presumably relies on the OS provided trust store so it would work if it's an "official TLS" cert like one signed by Let's Encrypt.
I must admit not knowing how to provide a different trusted CA if one doesn't have an official cert.
MusicDin
force-pushed
the
feat/pure-driver
branch
from
69f6cae to
231d0f0
Compare
MusicDin
force-pushed
the
feat/pure-driver
branch
from
231d0f0 to
276bb1b
Compare
|
@minaelee Thanks for the comments. I've addressed all of them, but will ask you for another review just before we merge the PR, as there may still be some changes to the docs. Thanks again :) |
| parentName, _, isSnapshot := api.GetParentAndSnapshotName(vol.Name()) | ||
| if !isSnapshot { | ||
| // Volume has no parent. | ||
| return "", nil |
There was a problem hiding this comment.
should this be an error as it means the vol passed in is not a snapshot and the function is being used incorrectly?
There was a problem hiding this comment.
I was thinking about this one, and decided to just return an empty string to avoid checking for snapshot on every place where the function is called. However, in such case the function name "GetParentVolumeUUID" would probably be more appropirate, as non-snapshot volumes have no parent.
On the other side, returning an error as you have suggested prevents unnecessary or incorrect usage of the function.
| } | ||
|
|
||
| reqHeaders := map[string]string{ | ||
| "Api-Token": p.driver.config["pure.api.token"], |
There was a problem hiding this comment.
does this need to have this casing of Api?
There was a problem hiding this comment.
Should not matter. I think it can be all lower case if preferred?
|
|
||
| p.accessToken = respHeaders["X-Auth-Token"] | ||
| if p.accessToken == "" { | ||
| return errors.New("Failed to obtain access token") |
There was a problem hiding this comment.
do we get any other sort of error message from this post?
There was a problem hiding this comment.
If we get any error from this post, it will be returned as "Failed to login: ".
For example: Error: Failed to create storage pool "pure": Failed to login: Unable to list user for API token where Unable to list user for API token is PureStorage error.
The check p.accessToken == "" is just to ensure that we also successfully parsed the the access token from the response. This code is only reached if Post request was successful.
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
…ce information Signed-off-by: Din Music <[email protected]>
…volumes Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
…zed images Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Pure Storage does not allow mounting snapshots directly, therefore we have to create a new volume from it before mounting it. Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Correctly initialize Pure Storage pool. Signed-off-by: Din Music <[email protected]>
…lable storage drivers Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Currently, Pure Storage driver does not support recovery. Mainly bacuse the storage volume names are encoded, which would result in indistinguishable storage volume names after the recovery. Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
… drivers Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
MusicDin
force-pushed
the
feat/pure-driver
branch
from
92bf8b5 to
bc794ea
Compare
MusicDin
changed the title
This PR adds
purestorage driver for Pure Storage remote storage.Driver supports communication over either iSCSI or NVMe/TCP.
iscsiadmto the LXD host: commands/daemon: Redirect iscsiadm to the host lxd-pkg-snap#646