From 40640ccecf352172c8311f070658415ae8cb9f97 Mon Sep 17 00:00:00 2001 From: Matthew Kosarek Date: Fri, 7 Feb 2025 11:43:36 -0500 Subject: [PATCH] (#3729) only connected outputs can be added to the output list --- .../gbm-kms/server/kms/real_kms_output_container.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/platforms/gbm-kms/server/kms/real_kms_output_container.cpp b/src/platforms/gbm-kms/server/kms/real_kms_output_container.cpp index dfe9e5cce8b..90ce85487cb 100644 --- a/src/platforms/gbm-kms/server/kms/real_kms_output_container.cpp +++ b/src/platforms/gbm-kms/server/kms/real_kms_output_container.cpp @@ -14,10 +14,12 @@ * along with this program. If not, see . */ +#define MIR_LOG_COMPONENT "gbm-kms" #include #include "real_kms_output_container.h" #include "real_kms_output.h" #include "kms-utils/drm_mode_resources.h" +#include namespace mgg = mir::graphics::gbm; @@ -55,6 +57,12 @@ void mgg::RealKMSOutputContainer::update_from_hardware_state() drm_fd == candidate->drm_fd(); }); + if (connector->connection != DRM_MODE_CONNECTED) + { + mir::log_warning("Connector is not connected, so not adding this output to the list."); + continue; + } + if (existing_output != outputs.end()) { // We could drop this down to O(n) by being smarter about moving out