Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove @BUILTIN_TESTLISTS mechanism #12

Open
mert-kirpici opened this issue Aug 17, 2023 · 0 comments
Open

remove @BUILTIN_TESTLISTS mechanism #12

mert-kirpici opened this issue Aug 17, 2023 · 0 comments
Labels
enhancement New feature or request medium Medium Priority

Comments

@mert-kirpici
Copy link
Contributor

I understand that the snap is trying to make it easy for the users to access the tests, however it really feels awkward to force users to use a variable with an @ sign inside quotes for this. Instead of this, running a properly documented

tempest run --load-list /snap/tempest/current/lists/read-only

really looks like a better choice imo since bash-completion will do most of the job for us and it is explicit.

Less preferably, another solution might be to introduce a new app in the snapcraft.yaml that copies over the test files. i.e.

tempest.copy-test-lists

or something named much better. So the user can run it after tempest init ws && cd ws to get the test-lists copied to their workspace.
@mert-kirpici mert-kirpici changed the title remove @BUILTIN_TESTS mechanism remove @BUILTIN_TESTLISTS mechanism Aug 17, 2023
@agileshaw agileshaw added enhancement New feature or request medium Medium Priority labels Nov 15, 2023
samuelallan72 added a commit that referenced this issue Jan 18, 2024
@samuelallan72
Remove BUILTIN_TESTLISTS to simplify things
6c03940 
The test lists are already in a well defined directory provided by snap,
so we can document them instead.
This both improves the user experience because command line completion
can be used for the test list paths,
and makes the code more maintainable by simplifying the logic.

Fixes #12

Fixes #74

Fixes #62
@samuelallan72 samuelallan72 mentioned this issue Jan 18, 2024
Closed
samuelallan72 added a commit that referenced this issue Jan 18, 2024
@samuelallan72
Remove BUILTIN_TESTLISTS to simplify things
90c1f24 
The test lists are already in a well defined directory provided by snap,
so we can document them instead.
This both improves the user experience because command line completion
can be used for the test list paths,
and makes the code more maintainable by simplifying the logic.

Fixes #12

Fixes #62
samuelallan72 added a commit that referenced this issue Jan 19, 2024
@samuelallan72
Remove BUILTIN_TESTLISTS to simplify things
1cb6dbd 
The test lists are already in a well defined directory provided by snap,
so we can document them instead.
This both improves the user experience because command line completion
can be used for the test list paths,
and makes the code more maintainable by simplifying the logic.

Fixes #12

Fixes #62
samuelallan72 added a commit that referenced this issue Mar 11, 2024
@samuelallan72
Remove BUILTIN_TESTLISTS to simplify things
11c8acf 
The test lists are already in a well defined directory provided by snap,
so we can document them instead.
This both improves the user experience because command line completion
can be used for the test list paths,
and makes the code more maintainable by simplifying the logic.

Fixes #12

Fixes #62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request medium Medium Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove BUILTIN_TESTLISTS to simplify things canonical/snap-tempest
2 participants
@agileshaw @mert-kirpici