-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
voice property should utilize voiceURI instead of an index #94
Comments
Also, related to #90 We could theoretically cache the list, but I'm not seeing anything guaranteeing that the list doesn't change, so caching seems unwise as compared to using unique identifiers. |
any solution with this 2024 |
Would like to see this also, I can do a PR but would like to know your preferred approach @robingenz
If you could let me know which would work best I'll submit a PR. |
@kieranbarlow Let me take another look at this in the next days. I will get back to you. |
I have just looked at this issue and wonder if it is still relevant. On Android, there was this commit a few months ago that was supposed to ensure that the same order was always returned. And on the web, the voices are cached so that the order cannot change (see here). |
@robingenz thanks for the reply. This is still an issue with iOS. For example, iOS has Jamie
|
@kieranbarlow Okay, feel free to create a PR that adds a new parameter |
Currently, especially on web, the list of available voices can change while the page is open. Uniquely identifying a specific voice (rather than the current system) avoids the risk of playing the wrong voice due to voices getting added, etc, while the page is open.
Additionally, at least on Android, voices are unordered - so this plugin needs to order the voices in a repeatable manner such that they can be located. I'm not actually sure if voices can change while the app is open, however either way, voiceURI would be less complicated.
Ideal Solution: voice property takes a string representing the voiceURI of the voice (or a separate option for voiceURI)
The text was updated successfully, but these errors were encountered: