Generate build failures (golden & delta) even if golden images are not present #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t present This is the 2nd PR to finally close cashapp#1716. Also relates to: - cashapp#1692 - cashapp#1695 since this still requires the presence of the `src/test/snapshots/images` input to work.
|
This solution relies on creating a fake/stub |
geoff-powell
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
I think this makes sense
cc @jrodbx @gamepro65 @nak5ive @BrianGardnerAtl
for thoughts here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 2nd PR to finally close #1716.
Also relates to:
since this still requires the presence of the
src/test/snapshots/imagesinput to work.