Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for longer notes #2

Open
cass-dlcm opened this issue Mar 22, 2021 · 3 comments
Open

Add support for longer notes #2

cass-dlcm opened this issue Mar 22, 2021 · 3 comments
Assignees
@cass-dlcm
Labels
enhancement New feature or request

Comments

@cass-dlcm
Copy link
Owner

Right now notes using the noteEvent function have a maximum length of 127 ticks. That's not quite enough for some compositions. I'd like to make it accept a variable-length quantity up to a DWORD in size, and perform validation (by external function) on it.
@cass-dlcm cass-dlcm added the enhancement New feature or request label Mar 22, 2021
@cass-dlcm
Copy link
Owner Author

cass-dlcm commented Mar 26, 2021 •
edited
Loading

  • add support for reading VLQs from data files
  • add support for writing VLQs to midi files

@cass-dlcm
Copy link
Owner Author

see commit 8fc8570 for changes

@cass-dlcm cass-dlcm reopened this Mar 28, 2021
@cass-dlcm
Copy link
Owner Author

Turns out that I need to add support for VLQs in the note event function that I wrote.
Did that in commit d05523f but ran into other issues.

@cass-dlcm cass-dlcm self-assigned this Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cass-dlcm cass-dlcm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cass-dlcm