Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conv_rnn refactoring #102

Open
lintool opened this issue May 16, 2018 · 2 comments
Open

conv_rnn refactoring #102

lintool opened this issue May 16, 2018 · 2 comments
Assignees
@daemon @Impavidity

Comments

@lintool
Copy link
Member

lintool commented May 16, 2018

Ref #99

conv_rnn and kim_cnn are both sentence classification models - they should share the same API, and in general be structured the same way.

@Impavidity @daemon please coordinate on this.
@daemon
Copy link
Member

daemon commented May 23, 2018

#99 #101
Maybe we can have all the shared modules in /common/ and the model-specific stuff in the current directories. For example, the user runs something like python -m conv_rnn from the base directory.

@tuzhucheng
Copy link
Member

SST-1 torchtext Dataset is now available in the datasets module. SST-2 will be added in the next 2 weeks.

@daemon daemon mentioned this issue Nov 28, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daemon daemon

@Impavidity Impavidity

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lintool @tuzhucheng @daemon @Impavidity