Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Add arm64 Mac testing #1054

Closed
2 tasks done
CodyCBakerPhD opened this issue Sep 3, 2024 · 1 comment · Fixed by #1061
Closed
2 tasks done

[Feature]: Add arm64 Mac testing #1054

CodyCBakerPhD opened this issue Sep 3, 2024 · 1 comment · Fixed by #1061
Assignees
@pauladkisson
Labels
enhancement testing

Comments

@CodyCBakerPhD
Copy link
Member

What would you like to see added to NeuroConv?

Just noticed that the testing matrix does not include macos-latest which uses arm64 (not intel) runners: https://github.com/catalystneuro/neuroconv/blob/main/.github/workflows/testing.yml#L23

Is your feature request related to a problem?

No response

Do you have any interest in helping implement the feature?

Yes.

Code of Conduct
@h-mayorquin
Copy link
Collaborator

I did not do this in spikeinterface because maxwell is failing but I had the vague memory that we don't really test for maxwell here.

@h-mayorquin h-mayorquin mentioned this issue Sep 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pauladkisson pauladkisson

Labels
enhancement testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable testing arm64 Mac architecture in the CI. catalystneuro/neuroconv
3 participants
@h-mayorquin @pauladkisson @CodyCBakerPhD