From 5dc29ab8cfaf74a43ec3c747513de78e2d8a4d19 Mon Sep 17 00:00:00 2001 From: Heberto Mayorquin Date: Wed, 21 Feb 2024 12:05:28 -0600 Subject: [PATCH 1/3] use relative paths instead of absolute for CI actions --- .github/workflows/dailies.yml | 6 +++--- .github/workflows/deploy-tests.yml | 10 +++++----- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/dailies.yml b/.github/workflows/dailies.yml index d2c932926..423548c66 100644 --- a/.github/workflows/dailies.yml +++ b/.github/workflows/dailies.yml @@ -8,14 +8,14 @@ on: jobs: run-daily-tests: - uses: catalystneuro/neuroconv/.github/workflows/testing.yml@main + uses: ./.github/workflows/testing.yml@main secrets: AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} S3_GIN_BUCKET: ${{ secrets.S3_GIN_BUCKET }} run-daily-doc-link-checks: - uses: catalystneuro/neuroconv/.github/workflows/test-external-links.yml@main + uses: ./.github/workflows/test-external-links.yml@main notify: runs-on: ubuntu-latest @@ -31,4 +31,4 @@ jobs: subject: NeuroConv Daily Failure to: ${{ secrets.DAILY_FAILURE_EMAIL_LIST }} # add more with commas, no separation from: NeuroConv - body: "The daily workflow for the NWB Inspector failed: please check status at https://github.com/catalystneuro/neuroconv/actions/workflows/dailies.yml" + body: "The daily workflow for the NWB Inspector failed: please check status at https://github.com/./actions/workflows/dailies.yml" diff --git a/.github/workflows/deploy-tests.yml b/.github/workflows/deploy-tests.yml index 334c7a3a9..41b5df102 100644 --- a/.github/workflows/deploy-tests.yml +++ b/.github/workflows/deploy-tests.yml @@ -12,7 +12,7 @@ concurrency: # Cancel previous workflows on the same pull request jobs: assess-file-changes: - uses: catalystneuro/neuroconv/.github/workflows/assess-file-changes.yml@main + uses: ./.github/workflows/assess-file-changes.yml@main detect-changelog-updates: needs: assess-file-changes @@ -30,7 +30,7 @@ jobs: run-tests: needs: assess-file-changes if: ${{ needs.assess-file-changes.outputs.SOURCE_CHANGED == 'true' }} - uses: catalystneuro/neuroconv/.github/workflows/testing.yml@main + uses: ./.github/workflows/testing.yml@main secrets: AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} @@ -40,14 +40,14 @@ jobs: run-live-service-tests: needs: assess-file-changes if: ${{ needs.assess-file-changes.outputs.SOURCE_CHANGED == 'true' }} - uses: catalystneuro/neuroconv/.github/workflows/live-service-testing.yml@main + uses: ./.github/workflows/live-service-testing.yml@main secrets: DANDI_API_KEY: ${{ secrets.DANDI_API_KEY }} run-dev-tests: needs: assess-file-changes if: ${{ needs.assess-file-changes.outputs.SOURCE_CHANGED == 'true' }} - uses: catalystneuro/neuroconv/.github/workflows/dev-testing.yml@main + uses: ./.github/workflows/dev-testing.yml@main secrets: DANDI_API_KEY: ${{ secrets.DANDI_API_KEY }} AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} @@ -57,7 +57,7 @@ jobs: run-doctests-only: needs: assess-file-changes if: ${{ needs.assess-file-changes.outputs.CONVERSION_GALLERY_CHANGED == 'true' || needs.assess-file-changes.outputs.SOURCE_CHANGED != 'true' }} - uses: catalystneuro/neuroconv/.github/workflows/doctests.yml@main + uses: ./.github/workflows/doctests.yml@main check-final-status: name: All tests passing From 875de8598a353699e97ba00e4e2460a473e67f87 Mon Sep 17 00:00:00 2001 From: Heberto Mayorquin Date: Wed, 21 Feb 2024 12:09:17 -0600 Subject: [PATCH 2/3] eliminate main references --- .github/workflows/dailies.yml | 4 ++-- .github/workflows/deploy-tests.yml | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/dailies.yml b/.github/workflows/dailies.yml index 423548c66..f35db6ef1 100644 --- a/.github/workflows/dailies.yml +++ b/.github/workflows/dailies.yml @@ -8,14 +8,14 @@ on: jobs: run-daily-tests: - uses: ./.github/workflows/testing.yml@main + uses: ./.github/workflows/testing.yml secrets: AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} S3_GIN_BUCKET: ${{ secrets.S3_GIN_BUCKET }} run-daily-doc-link-checks: - uses: ./.github/workflows/test-external-links.yml@main + uses: ./.github/workflows/test-external-links.yml notify: runs-on: ubuntu-latest diff --git a/.github/workflows/deploy-tests.yml b/.github/workflows/deploy-tests.yml index 41b5df102..72227839e 100644 --- a/.github/workflows/deploy-tests.yml +++ b/.github/workflows/deploy-tests.yml @@ -12,7 +12,7 @@ concurrency: # Cancel previous workflows on the same pull request jobs: assess-file-changes: - uses: ./.github/workflows/assess-file-changes.yml@main + uses: ./.github/workflows/assess-file-changes.yml detect-changelog-updates: needs: assess-file-changes @@ -30,7 +30,7 @@ jobs: run-tests: needs: assess-file-changes if: ${{ needs.assess-file-changes.outputs.SOURCE_CHANGED == 'true' }} - uses: ./.github/workflows/testing.yml@main + uses: ./.github/workflows/testing.yml secrets: AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} @@ -40,14 +40,14 @@ jobs: run-live-service-tests: needs: assess-file-changes if: ${{ needs.assess-file-changes.outputs.SOURCE_CHANGED == 'true' }} - uses: ./.github/workflows/live-service-testing.yml@main + uses: ./.github/workflows/live-service-testing.yml secrets: DANDI_API_KEY: ${{ secrets.DANDI_API_KEY }} run-dev-tests: needs: assess-file-changes if: ${{ needs.assess-file-changes.outputs.SOURCE_CHANGED == 'true' }} - uses: ./.github/workflows/dev-testing.yml@main + uses: ./.github/workflows/dev-testing.yml secrets: DANDI_API_KEY: ${{ secrets.DANDI_API_KEY }} AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} @@ -57,7 +57,7 @@ jobs: run-doctests-only: needs: assess-file-changes if: ${{ needs.assess-file-changes.outputs.CONVERSION_GALLERY_CHANGED == 'true' || needs.assess-file-changes.outputs.SOURCE_CHANGED != 'true' }} - uses: ./.github/workflows/doctests.yml@main + uses: ./.github/workflows/doctests.yml check-final-status: name: All tests passing From e5798a5dba95ac42ae84b62d6f71ee8901f9d25b Mon Sep 17 00:00:00 2001 From: Heberto Mayorquin Date: Wed, 21 Feb 2024 12:11:01 -0600 Subject: [PATCH 3/3] correct broken link --- .github/workflows/dailies.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/dailies.yml b/.github/workflows/dailies.yml index f35db6ef1..7264e7736 100644 --- a/.github/workflows/dailies.yml +++ b/.github/workflows/dailies.yml @@ -31,4 +31,4 @@ jobs: subject: NeuroConv Daily Failure to: ${{ secrets.DAILY_FAILURE_EMAIL_LIST }} # add more with commas, no separation from: NeuroConv - body: "The daily workflow for the NWB Inspector failed: please check status at https://github.com/./actions/workflows/dailies.yml" + body: "The daily workflow for the NWB Inspector failed: please check status at https://github.com/catalystneuro/neuroconv/actions/workflows/dailies.yml"