Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriptions don't necessarily get synchronized fully #325

Open
sylvansson opened this issue Oct 13, 2023 · 0 comments
Open

Subscriptions don't necessarily get synchronized fully #325

sylvansson opened this issue Oct 13, 2023 · 0 comments

Comments

@sylvansson
Copy link
Collaborator

When calling the syncSubscriptions route, we don't necessarily retrieve all subscriptions from Google Play, PayPal, and the database. For example, our current implementation of paypal.listPlans won't return more than 10 plans, and we don't specify a page size when calling Google Play so we'll get at most 50 subscriptions back.

The route probably works fine at the moment since we have a very small number of subscriptions and plans, but if that number grows we will eventually stop synchronizing plans properly.

Acceptance criteria

  • We retrieve all plans from PayPal.
  • We retrieve all subscriptions from Google Play.
  • We retrieve all subscriptions from the database.
  • Optionally, we stop fetching individual subscriptions from the database here. We're already getting the entire set of subscriptions so we can avoid making additional queries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant