Merge pull request #1028 from tomivm/fix/notification-bug

fix Notification permanence on dom after hide.
cboard-org · Sep 3, 2021 · b66c7a3 · b66c7a3
2 parents d21cefa + 2d4d82d
commit b66c7a3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 10 deletions.
diff --git a/src/components/Notifications/Notifications.component.js b/src/components/Notifications/Notifications.component.js
@@ -12,8 +12,7 @@ const propTypes = {
   handleNotificationDismissal: PropTypes.func.isRequired,
   message: PropTypes.string.isRequired,
   open: PropTypes.bool.isRequired,
-  kind: PropTypes.string,
-  showQueuedNotificationIfAny: PropTypes.func.isRequired
+  kind: PropTypes.string
 };
 
 function onRefreshPage() {
@@ -25,8 +24,7 @@ const Notifications = ({
   handleNotificationDismissal,
   message,
   open,
-  kind,
-  showQueuedNotificationIfAny
+  kind
 }) => (
   <Snackbar
     {...config}
@@ -35,11 +33,6 @@ const Notifications = ({
       variant: 'elevation',
       'aria-describedby': 'message-id'
     }}
-    TransitionProps={{
-      // show any queued notifications after the
-      // present one transitions out
-      onExited: showQueuedNotificationIfAny
-    }}
     message={<span id="message-id">{message}</span>}
     autoHideDuration={NOTIFICATION_DELAY}
     onClose={handleNotificationDismissal}

diff --git a/src/components/Notifications/Notifications.container.js b/src/components/Notifications/Notifications.container.js
@@ -69,6 +69,7 @@ class NotificationsContainer extends Component {
       return;
     }
     hideNotification();
+    this.showQueuedNotificationIfAny();
   };
 
   showQueuedNotificationIfAny = () => {
@@ -99,7 +100,6 @@ class NotificationsContainer extends Component {
         message={message}
         kind={kind}
         handleNotificationDismissal={this.handleNotificationDismissal}
-        showQueuedNotificationIfAny={this.showQueuedNotificationIfAny}
       />
     );
   }