Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argon2 v1.0 hashes might not include "v=16" parameter #54

Closed
Vlix opened this issue Jan 2, 2022 · 0 comments · Fixed by #56
Closed

Argon2 v1.0 hashes might not include "v=16" parameter #54

Vlix opened this issue Jan 2, 2022 · 0 comments · Fixed by #56
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Vlix
Copy link
Collaborator

Vlix commented Jan 2, 2022 •
edited
Loading

This kind of falls in the list of #11 , but is a bit more important.

Apparently the older version of Argon2 didn't always enforce the $v=16$ version parameter in the hash, so we should also accept hashes that do not include the version parameter and default it to Version10.

The change would basically only include Data.Password.Argon2.checkPassword.
@Vlix Vlix changed the title Argon2 v1.0 hashes might not include "v=10" parameter Argon2 v1.0 hashes might not include "v=16" parameter Jan 20, 2022
@Vlix Vlix added bug Something isn't working good first issue Good for newcomers labels Jan 26, 2022
@Vlix Vlix mentioned this issue Feb 13, 2022
Merged
@Vlix Vlix closed this as completed in #56 Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Argon2 v10 fix cdepillabout/password
1 participant
@Vlix