Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Angular 18 #1115

Closed
daine opened this issue Sep 4, 2024 · 1 comment
Closed

Add support for Angular 18 #1115

daine opened this issue Sep 4, 2024 · 1 comment
Labels
New | Nouveau New card, needs to be groomed

Comments

@daine
Copy link
Collaborator

daine commented Sep 4, 2024

📇 User story

This was a user submitted issue, where they had issues running npm install with @cdssnc/gcds-components-angular because the angular version in that package only supports up to version 16.

  • As a developer using the GCDS Components Angular package, I want to be able to run npm install without --legacy-peer-deps, so I can keep strict dependency resolution.

✅ Definition of Done / Outcomes

  • @cdssnc/gcds-components-angular is on version angular 18+

📜 Acceptance criteria

Add here the list of assumed steps that will be needed to complete the task

  • [ ]
  • [ ]

📝 More info

Stackblitz:
https://stackblitz.com/github/AlexisLeblancDFO/gcds-angular18-form?file=README.md

. 🚫 Out of scope
_ If possible, give precisions on what is not part of this work_

@daine daine added the New | Nouveau New card, needs to be groomed label Sep 4, 2024
@daine
Copy link
Collaborator Author

daine commented Sep 4, 2024

Closing, duplicate ticket of: cds-snc/gcds-components#628

@daine daine closed this as completed Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New | Nouveau New card, needs to be groomed
Projects
None yet
Development

No branches or pull requests

1 participant