Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: Align Search with Site Search Box (font size, border radius) #1335

Open
10 of 15 tasks
Tracked by #1274
realdylanzheng opened this issue Jan 20, 2025 · 3 comments
Open
10 of 15 tasks
Tracked by #1274
Assignees
Labels
development Development tasks Groomed Issues that have been refined and are ready to be worked on. High Priority | Haute priorité

Comments

@realdylanzheng
Copy link

realdylanzheng commented Jan 20, 2025

📇 User Story or Summary

As a developer, I want the font size on the search component to be smaller than 20px, and I want the rounded corners removed to complete the alignment work with Canada.ca

Design file

Search (opens in Figma)

✅ Definition of Done / Outcomes

  • Done when a PR is reviewed and approved on the tokens repository
  • Done when the PR on the tokens repository is merged and released
  • Done when a PR on the components repository is approved and ready to merge, but not yet merged
  • Done when PR on the components repository has been reviewed by at least 1 dev
  • Done when tests are written and passing
  • Done when the requirements doc has been updated to include the changes

📜 Acceptance criteria

  • The font size on the search input is set to 16px on mobile to align with Canada.ca
  • The font size on the search input is set to 16px on desktop to align with Canada.ca
  • Ensure the size is set to 34 characters for the input element
  • Ensure the max-length is set to 170 for the input element
  • The rounded corners, or border radius, on the search component should be removed or set to none.
  • The component tokens gcds-search-font-desktop and gcds-search-font-mobile for the search component should be updated to use a smaller font size (1rem or 16px)
  • The CSS for the component token has been updated to remove the rounded borders
  • PR on the components repository needs to be reviewed by at least 1 designer
  • PR on the components repository, while approved, should not yet be merged

Out of scope:

  • Colour
  • Button / icon font size
@adorayi adorayi added For Grooming Issues with this label will be prioritized in the next team grooming session and likely next sprint High Priority | Haute priorité labels Jan 22, 2025
@adorayi
Copy link
Contributor

adorayi commented Jan 22, 2025

Missing acceptance criteria for size of the search input to be set to size 34

@adorayi
Copy link
Contributor

adorayi commented Jan 22, 2025

What happens when the search component is used outside of the header? re: responsive vs non responsive use.
Follow up with @jmealing in the next meeting, how should the Search component be used outside of the header. See Canada.ca Search results page.

@jmealing
Copy link
Collaborator

@realdylanzheng Could we plan to touch base and discuss in one of our design sprints; maybe the 29th?

@daine daine changed the title Dev: Align Search with Site Search Box Dev: Align Search with Site Search Box (font size, border radius) Jan 27, 2025
@daine daine added Groomed Issues that have been refined and are ready to be worked on. and removed For Grooming Issues with this label will be prioritized in the next team grooming session and likely next sprint labels Jan 27, 2025
@daine daine added the development Development tasks label Jan 27, 2025
@ethanWallace ethanWallace self-assigned this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Development tasks Groomed Issues that have been refined and are ready to be worked on. High Priority | Haute priorité
Projects
None yet
Development

No branches or pull requests

5 participants