Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove component-id attributes from form components #584

Open
5 tasks
ethanWallace opened this issue Jul 16, 2024 · 0 comments
Open
5 tasks

Remove component-id attributes from form components #584

ethanWallace opened this issue Jul 16, 2024 · 0 comments
Labels

Comments

@ethanWallace
Copy link
Collaborator

Summary

Remove the <component>-id attributes from form components as they no longer serve a purpose.

Previously the id attributes were to assign the unique identifier for form elements generated by the component in the light-dom so the developer had to pass a unique id. With the form-associated release, form components now use shadow-dom so the requirement of a unique id is no longer required.

Acceptance criteria

  • Id attributes have been removed from form components
  • Storybook stories are updated
  • Mention of the id attributes has been removed from code guidance.

Definition of done

  • New component package has been published
  • Guidance has been updated to reflect new changes
@daine daine added the development Development tasks label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants