Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: v-model not working on gcds-checkbox #629

Open
ethanWallace opened this issue Sep 4, 2024 · 4 comments
Open

bug: v-model not working on gcds-checkbox #629

ethanWallace opened this issue Sep 4, 2024 · 4 comments
Assignees
Labels
bug Something isn't working development Development tasks Groomed Issues that have been refined and are ready to be worked on. High Priority | Haute priorité

Comments

@ethanWallace
Copy link
Collaborator

ethanWallace commented Sep 4, 2024

Context : Issue was flagged first by DFO user , but product team ended creating the ticket

As noted in this comment the v-model is not working properly for the gcds-checkbox component in Vue.

Example

https://stackblitz.com/edit/vitejs-vite-vmu2f2?file=src%2FApp.vue

<script setup>
import { ref } from 'vue'
const checkboxValue = ref(false)
</script>

<template>
<gcds-checkbox
    checkbox-id="checkbox-default"
    label="CheckboxLabel"
    name="checkbox"
    hint="Description or example to make the option clearer."
    v-model="checkboxValue"
    >
</gcds-checkbox>
</template>
@ethanWallace ethanWallace added bug Something isn't working For Grooming labels Sep 4, 2024
@adorayi adorayi added High Priority | Haute priorité Groomed Issues that have been refined and are ready to be worked on. and removed For Grooming labels Sep 4, 2024
@adorayi
Copy link

adorayi commented Sep 4, 2024

Start with investigation.

@ethanWallace
Copy link
Collaborator Author

Might need to configure componentModel in output configuration for gcds-checkbox https://stenciljs.com/docs/vue#componentmodels

@ethanWallace ethanWallace self-assigned this Sep 16, 2024
@ClementineHahn
Copy link

Being tackled today to investigate

@daine
Copy link
Collaborator

daine commented Oct 2, 2024

Pausing on this since we are revisiting the checkbox component soon

@daine daine added the development Development tasks label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working development Development tasks Groomed Issues that have been refined and are ready to be worked on. High Priority | Haute priorité
Projects
None yet
Development

No branches or pull requests

4 participants