Feat/provide list of sending domains #2018
Open
+145
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
This PR updates the sending domain admin page to use a list of verified sending domains from AWS instead of a drop down list which could allow users to enter invalid domains into.
Since this lists rarely changes the request to SES is cached for 5 minutes so we don't send too many requests.
Related cards
Before - textbox
After - dropdown
Test instructions | Instructions pour tester la modification