Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add banner for caretaker period behind feature flag #5055

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

anikbrazeau
Copy link
Member

@anikbrazeau anikbrazeau commented Jan 29, 2025

Fixes #5044

  • Reviewed by Policy
  • Reviewed by Product
  • Reviewed by Dev

To be released when writ drops for election period

Copy link
Contributor

@@ -206,7 +206,9 @@
"type": "À VENIR",
"message": "<strong>En août</strong> : Créez des formulaires multipages avec une logique d’embranchement. <a href='/fr/contact' className='text-white hover:text-white'>S’abonner aux mises à jour</a>",
"type2": "NOUVEAUTÉ",
"message2": "Créez des formulaires complexes de plusieurs pages avec logique d’affichage et d’embranchement. <a href='https://articles.alpha.canada.ca/forms-formulaires/fr/configurer-formulaire-avec-logique/' className='text-white hover:text-white'>En savoir plus</a>"
"message2": "Créez des formulaires complexes de plusieurs pages avec logique d’affichage et d’embranchement. <a href='https://articles.alpha.canada.ca/forms-formulaires/fr/configurer-formulaire-avec-logique/' className='text-white hover:text-white'>En savoir plus</a>",
"type3": "Election period",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing translation ?

@timarney
Copy link
Member

timarney commented Jan 30, 2025

Looks good --- noting the is a little different vs other feature flags and will require a release to turn on (which is fine).

The release will just need to update translation files

"campaignBanner": {
    "enabled": "true",

Noting this one is safe to merge whenever as it's "off"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add caretaker period warning.
2 participants