-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add banner for caretaker period behind feature flag #5055
base: main
Are you sure you want to change the base?
Conversation
🧪 Review environmenthttps://jqra3lpyi7py3melmrponwqqkq0xfmef.lambda-url.ca-central-1.on.aws/ |
@@ -206,7 +206,9 @@ | |||
"type": "À VENIR", | |||
"message": "<strong>En août</strong> : Créez des formulaires multipages avec une logique d’embranchement. <a href='/fr/contact' className='text-white hover:text-white'>S’abonner aux mises à jour</a>", | |||
"type2": "NOUVEAUTÉ", | |||
"message2": "Créez des formulaires complexes de plusieurs pages avec logique d’affichage et d’embranchement. <a href='https://articles.alpha.canada.ca/forms-formulaires/fr/configurer-formulaire-avec-logique/' className='text-white hover:text-white'>En savoir plus</a>" | |||
"message2": "Créez des formulaires complexes de plusieurs pages avec logique d’affichage et d’embranchement. <a href='https://articles.alpha.canada.ca/forms-formulaires/fr/configurer-formulaire-avec-logique/' className='text-white hover:text-white'>En savoir plus</a>", | |||
"type3": "Election period", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation ?
Looks good --- noting the is a little different vs other feature flags and will require a release to turn on (which is fine). The release will just need to update translation files
Noting this one is safe to merge whenever as it's "off" |
Fixes #5044
To be released when writ drops for election period