Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pagination feature is broken due to integration of new StatusCreatedAt Global Secondary Index #4818

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

craigzour
Copy link
Contributor

@craigzour craigzour commented Dec 11, 2024

Summary | Résumé

  • Fixes pagination feature so that it uses the right lastEvaluatedKey for the DynamoDB query when listing submissions

Test instructions | Instructions pour tester la modification

  • Use a form that has enough responses so that the pagination feature is available (2 pages is good enough)
  • While on page 1 navigate to page 2
  • See if it works (on Staging it just returns an error message)

@craigzour craigzour self-assigned this Dec 11, 2024
Copy link
Contributor

@craigzour craigzour force-pushed the fix/new-gsi-pagination-bug branch from 0f1fa30 to d8d2ca3 Compare December 11, 2024 18:13
@craigzour craigzour marked this pull request as ready for review December 11, 2024 18:27
@@ -845,3 +865,19 @@ export const confirmResponses = async (
}),
};
};

export function vaultStatusFromStatusCreatedAt(statusCreatedAtAttribute: string): VaultStatus {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function is exported as it will be used in a subsequent PR #4707

@craigzour craigzour merged commit 0ffdaca into main Dec 12, 2024
13 checks passed
@craigzour craigzour deleted the fix/new-gsi-pagination-bug branch December 12, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants