Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeout config override in e2e test #4023

Open
evan-forbes opened this issue Nov 6, 2024 · 3 comments
Open

Fix timeout config override in e2e test #4023

evan-forbes opened this issue Nov 6, 2024 · 3 comments
Labels
WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc

Comments

@evan-forbes
Copy link
Member

evan-forbes commented Nov 6, 2024

Build tags are not working or not applied to the e2e tests, therefore we either need to fix them or use a different mechanism.

Previously in testground, we were using a specific version to do this. With the latest v3 release, we are incorporating the chain-id into the logic of the state machine, which would allow for such a change.

@evan-forbes evan-forbes added WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc WS: V3 3️⃣ item is directly relevant to the v3 hardfork and removed needs:triage labels Nov 6, 2024
@evan-forbes evan-forbes self-assigned this Nov 11, 2024
@rootulp
Copy link
Collaborator

rootulp commented Dec 9, 2024

#3897 are not working or not applied to the e2e tests, therefore we either need to fix them or use a different mechanism.

There is no build tag for timeout_commit. There was a build tag for overriding the upgrade height delay but that was removed in favor of overriding it based on chain id.

Is this issue for overriding the upgrade height delay or timeout_commit?

@evan-forbes
Copy link
Member Author

Is this issue for overriding the upgrade height delay or timeout_commit?

good point, I think it should be the upgrade delay

could do both tho with #4080

@evan-forbes evan-forbes removed their assignment Dec 9, 2024
@evan-forbes evan-forbes removed the WS: V3 3️⃣ item is directly relevant to the v3 hardfork label Dec 9, 2024
@rootulp
Copy link
Collaborator

rootulp commented Dec 9, 2024

#4090 configured the e2e to use the test chain ID which will make upgrade height delay small (3 blocks).

If that's it then we can close this as a dupe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc
Projects
None yet
Development

No branches or pull requests

2 participants