Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate ledger-go 1.0.0 #4106

Open
3 tasks done
rootulp opened this issue Dec 10, 2024 · 1 comment
Open
3 tasks done

Investigate ledger-go 1.0.0 #4106

rootulp opened this issue Dec 10, 2024 · 1 comment
Assignees
@rootulp
Labels
investigation item tracks efforts related to an investigation. does not always require a PR to close. needs:investigation more knowledge is required before item can be groomed

Comments

@rootulp
Copy link
Collaborator

rootulp commented Dec 10, 2024 •
edited
Loading

Context

osmosis-labs/osmosis#8872

Problem

There may be an issue with the latest Ledger software.

Proposal
@rootulp rootulp self-assigned this Dec 10, 2024
@rootulp
Copy link
Collaborator Author

rootulp commented Dec 10, 2024

We use

celestia-app/go.mod

Lines 258 to 260 in 818026a

// Pin to ledger-cosmos-go v0.12.4 to avoid a breaking change introduced in v0.13.0
// The following replace statement can be removed when we upgrade to cosmos-sdk >= v0.50.0
github.com/cosmos/ledger-cosmos-go => github.com/cosmos/ledger-cosmos-go v0.12.4
and the linked PR bumps https://github.com/zondax/ledger-go which we only depend on indirectly

celestia-app/go.mod

Line 218 in 818026a

github.com/zondax/ledger-go v0.14.3 // indirect

@rootulp rootulp added investigation item tracks efforts related to an investigation. does not always require a PR to close. needs:investigation more knowledge is required before item can be groomed and removed needs:triage labels Dec 10, 2024
@rootulp rootulp mentioned this issue Dec 10, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
investigation item tracks efforts related to an investigation. does not always require a PR to close. needs:investigation more knowledge is required before item can be groomed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rootulp