From dd31ca68d9a80f22374dc463939d79e73301d9a0 Mon Sep 17 00:00:00 2001 From: sanaz Date: Mon, 8 Jul 2024 12:03:23 -0700 Subject: [PATCH 01/29] checks the target size against the max block size --- test/e2e/benchmark/benchmark.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/e2e/benchmark/benchmark.go b/test/e2e/benchmark/benchmark.go index cb1a678e5e..baee5a2881 100644 --- a/test/e2e/benchmark/benchmark.go +++ b/test/e2e/benchmark/benchmark.go @@ -160,13 +160,13 @@ func (b *BenchmarkTest) CheckResults(expectedBlockSizeBytes int64) error { return fmt.Errorf("expected app version %d, got %d", appconsts.LatestVersion, block.Version.App) } size := int64(block.Size()) - if size >= expectedBlockSizeBytes { - targetSizeReached = true - break - } if size > maxBlockSize { maxBlockSize = size } + if maxBlockSize >= expectedBlockSizeBytes { + targetSizeReached = true + break + } } if !targetSizeReached { return fmt.Errorf("max reached block size is %d byte and is not within the expected range of %d and %d bytes", maxBlockSize, expectedBlockSizeBytes, b.manifest.MaxBlockBytes) From 810bf331a3ac61da67ac48a6ec43b912538d8488 Mon Sep 17 00:00:00 2001 From: sanaz Date: Mon, 8 Jul 2024 12:03:43 -0700 Subject: [PATCH 02/29] removes unnecessary usage of Printf for logs --- test/e2e/benchmark/throughput.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/e2e/benchmark/throughput.go b/test/e2e/benchmark/throughput.go index ef0080029e..4fe0d84250 100644 --- a/test/e2e/benchmark/throughput.go +++ b/test/e2e/benchmark/throughput.go @@ -58,7 +58,7 @@ func TwoNodeSimple(logger *log.Logger) error { testnet.NoError("failed to get latest version", err) testName := "TwoNodeSimple" - logger.Printf("Running %s\n", testName) + logger.Println("Running", testName) logger.Println("version", latestVersion) manifest := Manifest{ @@ -108,7 +108,7 @@ func TwoNodeSimple(logger *log.Logger) error { } func runBenchmarkTest(logger *log.Logger, testName string, manifest Manifest) error { - logger.Printf("Running %s\n", testName) + logger.Println("Running", testName) manifest.ChainID = manifest.summary() log.Println("ChainID: ", manifest.ChainID) benchTest, err := NewBenchmarkTest(testName, &manifest) From d09f00f8dea3f8614ed3e915248f50962477112a Mon Sep 17 00:00:00 2001 From: sanaz Date: Mon, 8 Jul 2024 13:16:40 -0700 Subject: [PATCH 03/29] adds benchtest with latency --- test/e2e/benchmark/throughput.go | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/test/e2e/benchmark/throughput.go b/test/e2e/benchmark/throughput.go index 4fe0d84250..20388e2410 100644 --- a/test/e2e/benchmark/throughput.go +++ b/test/e2e/benchmark/throughput.go @@ -179,3 +179,14 @@ func LargeNetworkBigBlock64MB(logger *log.Logger) error { manifest.BlobSequences = 2 return runBenchmarkTest(logger, "LargeNetworkBigBlock64MB", manifest) } + +func LargeNetworkBigBlock64MBLatency(logger *log.Logger) error { + manifest := bigBlockManifest + manifest.MaxBlockBytes = 64 * testnet.MB + manifest.Validators = 50 + manifest.TxClients = 50 + manifest.BlobSequences = 2 + manifest.EnableLatency = true + manifest.LatencyParams = LatencyParams{70, 0} + return runBenchmarkTest(logger, "LargeNetworkBigBlock64MB", manifest) +} From 0d9abd00bf3050275b25c18d51f631d31f64ffb0 Mon Sep 17 00:00:00 2001 From: sanaz Date: Mon, 8 Jul 2024 14:32:46 -0700 Subject: [PATCH 04/29] adds ReadBlockchainInfo --- test/util/testnode/read.go | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/test/util/testnode/read.go b/test/util/testnode/read.go index 1e5983480c..5245397c67 100644 --- a/test/util/testnode/read.go +++ b/test/util/testnode/read.go @@ -9,6 +9,7 @@ import ( "github.com/celestiaorg/go-square/blob" sdk "github.com/cosmos/cosmos-sdk/types" "github.com/tendermint/tendermint/rpc/client/http" + ctypes "github.com/tendermint/tendermint/rpc/core/types" "github.com/tendermint/tendermint/types" ) @@ -39,6 +40,26 @@ func ReadBlockchain(ctx context.Context, rpcAddress string) ([]*types.Block, err return ReadBlockHeights(ctx, rpcAddress, 1, status.SyncInfo.LatestBlockHeight) } +// ReadBlockchainInfo reads the blockchain info from the node at rpcAddress and returns it. +func ReadBlockchainInfo(ctx context.Context, rpcAddress string) (*ctypes.ResultBlockchainInfo, + error) { + client, err := http.New(rpcAddress, "/websocket") + if err != nil { + return nil, err + } + resp, err := client.Status(ctx) + if err != nil { + return nil, err + + } + lastHeight := resp.SyncInfo.LatestBlockHeight + res, err := client.BlockchainInfo(ctx, 0, lastHeight) + if err != nil { + return nil, err + } + return res, nil +} + func ReadBlockHeights(ctx context.Context, rpcAddress string, fromHeight, toHeight int64) ([]*types.Block, error) { client, err := http.New(rpcAddress, "/websocket") if err != nil { From 48adbefe064279c2454da8f564b63a2c0fbc6556 Mon Sep 17 00:00:00 2001 From: sanaz Date: Mon, 8 Jul 2024 14:33:51 -0700 Subject: [PATCH 05/29] retrieves block metadata --- test/e2e/benchmark/benchmark.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/test/e2e/benchmark/benchmark.go b/test/e2e/benchmark/benchmark.go index cb1a678e5e..2f49006409 100644 --- a/test/e2e/benchmark/benchmark.go +++ b/test/e2e/benchmark/benchmark.go @@ -149,17 +149,17 @@ func (b *BenchmarkTest) CheckResults(expectedBlockSizeBytes int64) error { } log.Println("Reading blockchain") - blockchain, err := testnode.ReadBlockchain(context.Background(), + blockchain, err := testnode.ReadBlockchainInfo(context.Background(), b.Node(0).AddressRPC()) - testnet.NoError("failed to read blockchain", err) + testnet.NoError("failed to read blockchain information", err) targetSizeReached := false maxBlockSize := int64(0) - for _, block := range blockchain { - if appconsts.LatestVersion != block.Version.App { - return fmt.Errorf("expected app version %d, got %d", appconsts.LatestVersion, block.Version.App) + for _, blockMeta := range blockchain.BlockMetas { + if appconsts.LatestVersion != blockMeta.Header.Version.App { + return fmt.Errorf("expected app version %d, got %d", appconsts.LatestVersion, blockMeta.Header.Version.App) } - size := int64(block.Size()) + size := int64(blockMeta.BlockSize) if size >= expectedBlockSizeBytes { targetSizeReached = true break From 423a8db2f8342c2178aa57a61f147d725a9218a9 Mon Sep 17 00:00:00 2001 From: sanaz Date: Mon, 8 Jul 2024 14:34:25 -0700 Subject: [PATCH 06/29] reads block headers in E2ESimple --- test/e2e/simple.go | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/test/e2e/simple.go b/test/e2e/simple.go index 9cb2699310..b4c98aa3f4 100644 --- a/test/e2e/simple.go +++ b/test/e2e/simple.go @@ -44,15 +44,16 @@ func E2ESimple(logger *log.Logger) error { time.Sleep(30 * time.Second) logger.Println("Reading blockchain") - blockchain, err := testnode.ReadBlockchain(context.Background(), testNet.Node(0).AddressRPC()) + blockchain, err := testnode.ReadBlockchainInfo(context.Background(), testNet.Node(0).AddressRPC()) testnet.NoError("failed to read blockchain", err) totalTxs := 0 - for _, block := range blockchain { - if appconsts.LatestVersion != block.Version.App { - return fmt.Errorf("expected app version %d, got %d in block %d", appconsts.LatestVersion, block.Version.App, block.Height) + for _, blockMeta := range blockchain.BlockMetas { + version := blockMeta.Header.Version.App + if appconsts.LatestVersion != version { + return fmt.Errorf("expected app version %d, got %d in blockMeta %d", appconsts.LatestVersion, version, blockMeta.Header.Height) } - totalTxs += len(block.Data.Txs) + totalTxs += blockMeta.NumTxs } if totalTxs < 10 { return fmt.Errorf("expected at least 10 transactions, got %d", totalTxs) From 48a7014525ceb607cb24f862fa1e0591b0e417f5 Mon Sep 17 00:00:00 2001 From: sanaz Date: Mon, 8 Jul 2024 14:37:22 -0700 Subject: [PATCH 07/29] updates log messages --- test/e2e/simple.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/e2e/simple.go b/test/e2e/simple.go index b4c98aa3f4..8428fde9e5 100644 --- a/test/e2e/simple.go +++ b/test/e2e/simple.go @@ -43,9 +43,9 @@ func E2ESimple(logger *log.Logger) error { // wait for 30 seconds time.Sleep(30 * time.Second) - logger.Println("Reading blockchain") + logger.Println("Reading blockchain information") blockchain, err := testnode.ReadBlockchainInfo(context.Background(), testNet.Node(0).AddressRPC()) - testnet.NoError("failed to read blockchain", err) + testnet.NoError("failed to read blockchain information", err) totalTxs := 0 for _, blockMeta := range blockchain.BlockMetas { From 3b87baadad75b6f83a84d18fb0f4e2605a948605 Mon Sep 17 00:00:00 2001 From: sanaz Date: Mon, 8 Jul 2024 14:58:19 -0700 Subject: [PATCH 08/29] resolves linter issues --- test/util/testnode/read.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/test/util/testnode/read.go b/test/util/testnode/read.go index 5245397c67..acd03a329c 100644 --- a/test/util/testnode/read.go +++ b/test/util/testnode/read.go @@ -41,8 +41,7 @@ func ReadBlockchain(ctx context.Context, rpcAddress string) ([]*types.Block, err } // ReadBlockchainInfo reads the blockchain info from the node at rpcAddress and returns it. -func ReadBlockchainInfo(ctx context.Context, rpcAddress string) (*ctypes.ResultBlockchainInfo, - error) { +func ReadBlockchainInfo(ctx context.Context, rpcAddress string) (*ctypes.ResultBlockchainInfo, error) { client, err := http.New(rpcAddress, "/websocket") if err != nil { return nil, err @@ -50,7 +49,6 @@ func ReadBlockchainInfo(ctx context.Context, rpcAddress string) (*ctypes.ResultB resp, err := client.Status(ctx) if err != nil { return nil, err - } lastHeight := resp.SyncInfo.LatestBlockHeight res, err := client.BlockchainInfo(ctx, 0, lastHeight) From 8ee445feb026396a37a131ce69305dec2f1962b7 Mon Sep 17 00:00:00 2001 From: sanaz Date: Mon, 8 Jul 2024 15:09:36 -0700 Subject: [PATCH 09/29] increase seq count per txclient in E2ESimple --- test/e2e/simple.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/e2e/simple.go b/test/e2e/simple.go index 8428fde9e5..6d1eab2e19 100644 --- a/test/e2e/simple.go +++ b/test/e2e/simple.go @@ -31,7 +31,8 @@ func E2ESimple(logger *log.Logger) error { logger.Println("Creating txsim") endpoints, err := testNet.RemoteGRPCEndpoints() testnet.NoError("failed to get remote gRPC endpoints", err) - err = testNet.CreateTxClient("txsim", testnet.TxsimVersion, 1, "100-2000", 100, testnet.DefaultResources, endpoints[0]) + err = testNet.CreateTxClient("txsim", testnet.TxsimVersion, 10, + "100-2000", 100, testnet.DefaultResources, endpoints[0]) testnet.NoError("failed to create tx client", err) logger.Println("Setting up testnets") From 3af0a79026b8270fc4a38ef4cfdc55ebe8f4e1f1 Mon Sep 17 00:00:00 2001 From: sanaz Date: Mon, 8 Jul 2024 15:23:18 -0700 Subject: [PATCH 10/29] expands on the godoc --- test/util/testnode/read.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/util/testnode/read.go b/test/util/testnode/read.go index acd03a329c..92c0198873 100644 --- a/test/util/testnode/read.go +++ b/test/util/testnode/read.go @@ -40,7 +40,8 @@ func ReadBlockchain(ctx context.Context, rpcAddress string) ([]*types.Block, err return ReadBlockHeights(ctx, rpcAddress, 1, status.SyncInfo.LatestBlockHeight) } -// ReadBlockchainInfo reads the blockchain info from the node at rpcAddress and returns it. +// ReadBlockchainInfo retrieves the blockchain information from height 0 up to the latest height from the node at +// rpcAddress and returns it. func ReadBlockchainInfo(ctx context.Context, rpcAddress string) (*ctypes.ResultBlockchainInfo, error) { client, err := http.New(rpcAddress, "/websocket") if err != nil { From e4e53332a00fb07db34bf9e5b707af99390a4e6c Mon Sep 17 00:00:00 2001 From: sanaz Date: Tue, 9 Jul 2024 10:20:12 -0700 Subject: [PATCH 11/29] includes LargeNetworkBigBlock64MBLatency in the list of available tests --- test/e2e/benchmark/main.go | 1 + 1 file changed, 1 insertion(+) diff --git a/test/e2e/benchmark/main.go b/test/e2e/benchmark/main.go index be4eb1e126..00bcaec154 100644 --- a/test/e2e/benchmark/main.go +++ b/test/e2e/benchmark/main.go @@ -18,6 +18,7 @@ func main() { {"LargeNetworkBigBlock8MB", LargeNetworkBigBlock8MB}, {"LargeNetworkBigBlock32MB", LargeNetworkBigBlock32MB}, {"LargeNetworkBigBlock64MB", LargeNetworkBigBlock64MB}, + {"LargeNetworkBigBlock64MBLatency", LargeNetworkBigBlock64MBLatency}, } // check the test name passed as an argument and run it From b7896f36f10173e454cfd1e24351689601635db5 Mon Sep 17 00:00:00 2001 From: sanaz Date: Tue, 9 Jul 2024 10:37:02 -0700 Subject: [PATCH 12/29] sets txsim volume to 0 --- test/e2e/testnet/defaults.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e/testnet/defaults.go b/test/e2e/testnet/defaults.go index 1ea4bbb585..754a1bf8b5 100644 --- a/test/e2e/testnet/defaults.go +++ b/test/e2e/testnet/defaults.go @@ -4,7 +4,7 @@ var DefaultResources = Resources{ MemoryRequest: "400Mi", MemoryLimit: "400Mi", CPU: "300m", - Volume: "1Gi", + Volume: "0Gi", } const ( From d09f96ee24ae4c9e6f922eedffc15d476e48979e Mon Sep 17 00:00:00 2001 From: sanaz Date: Wed, 10 Jul 2024 15:34:01 -0700 Subject: [PATCH 13/29] reads the entire history --- test/util/testnode/read.go | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/test/util/testnode/read.go b/test/util/testnode/read.go index 92c0198873..b85a1d9947 100644 --- a/test/util/testnode/read.go +++ b/test/util/testnode/read.go @@ -9,7 +9,6 @@ import ( "github.com/celestiaorg/go-square/blob" sdk "github.com/cosmos/cosmos-sdk/types" "github.com/tendermint/tendermint/rpc/client/http" - ctypes "github.com/tendermint/tendermint/rpc/core/types" "github.com/tendermint/tendermint/types" ) @@ -42,7 +41,7 @@ func ReadBlockchain(ctx context.Context, rpcAddress string) ([]*types.Block, err // ReadBlockchainInfo retrieves the blockchain information from height 0 up to the latest height from the node at // rpcAddress and returns it. -func ReadBlockchainInfo(ctx context.Context, rpcAddress string) (*ctypes.ResultBlockchainInfo, error) { +func ReadBlockchainInfo(ctx context.Context, rpcAddress string) ([]*types.BlockMeta, error) { client, err := http.New(rpcAddress, "/websocket") if err != nil { return nil, err @@ -51,12 +50,23 @@ func ReadBlockchainInfo(ctx context.Context, rpcAddress string) (*ctypes.ResultB if err != nil { return nil, err } + blocksMeta := make([]*types.BlockMeta, 0) lastHeight := resp.SyncInfo.LatestBlockHeight - res, err := client.BlockchainInfo(ctx, 0, lastHeight) - if err != nil { - return nil, err + i := int64(0) + for { + print("Reading blockchain info from height ", i, " to ", lastHeight, "\n") + res, err := client.BlockchainInfo(ctx, i, lastHeight) + if err != nil { + return nil, err + } + blocksMeta = append(blocksMeta, res.BlockMetas...) + if res.LastHeight == 0 || res.LastHeight >= lastHeight { + break + } + i += res.LastHeight } - return res, nil + + return blocksMeta, nil } func ReadBlockHeights(ctx context.Context, rpcAddress string, fromHeight, toHeight int64) ([]*types.Block, error) { From 2909d2e148f798c4ed205f893ccedf542e37f7eb Mon Sep 17 00:00:00 2001 From: sanaz Date: Wed, 10 Jul 2024 18:14:21 -0700 Subject: [PATCH 14/29] extends wait time --- test/e2e/testnet/testnet.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/e2e/testnet/testnet.go b/test/e2e/testnet/testnet.go index e300a77288..b0f500d8eb 100644 --- a/test/e2e/testnet/testnet.go +++ b/test/e2e/testnet/testnet.go @@ -356,10 +356,10 @@ func (t *Testnet) Start() error { if err != nil { return fmt.Errorf("failed to initialized node %s: %w", node.Name, err) } - for i := 0; i < 10; i++ { + for i := 0; i < 20; i++ { resp, err := client.Status(context.Background()) if err != nil { - if i == 9 { + if i == 19 { return fmt.Errorf("node %s status response: %w", node.Name, err) } time.Sleep(time.Second) @@ -372,7 +372,7 @@ func (t *Testnet) Start() error { } log.Info().Int64("height", resp.SyncInfo.LatestBlockHeight).Msg( "height is 0, waiting...") - if i == 9 { + if i == 19 { return fmt.Errorf("failed to start node %s", node.Name) } fmt.Printf("node %s is not synced yet, waiting...\n", node.Name) From 0f218bb7bb9072c58ab403f1d13c8773e8b3c98b Mon Sep 17 00:00:00 2001 From: sanaz Date: Wed, 10 Jul 2024 18:14:51 -0700 Subject: [PATCH 15/29] updates read blockchain info --- test/e2e/benchmark/benchmark.go | 2 +- test/e2e/simple.go | 2 +- test/util/testnode/read.go | 27 +++++++++++++++++++++------ 3 files changed, 23 insertions(+), 8 deletions(-) diff --git a/test/e2e/benchmark/benchmark.go b/test/e2e/benchmark/benchmark.go index 2f49006409..39a2022e84 100644 --- a/test/e2e/benchmark/benchmark.go +++ b/test/e2e/benchmark/benchmark.go @@ -155,7 +155,7 @@ func (b *BenchmarkTest) CheckResults(expectedBlockSizeBytes int64) error { targetSizeReached := false maxBlockSize := int64(0) - for _, blockMeta := range blockchain.BlockMetas { + for _, blockMeta := range blockchain { if appconsts.LatestVersion != blockMeta.Header.Version.App { return fmt.Errorf("expected app version %d, got %d", appconsts.LatestVersion, blockMeta.Header.Version.App) } diff --git a/test/e2e/simple.go b/test/e2e/simple.go index 6d1eab2e19..2a148f3ddf 100644 --- a/test/e2e/simple.go +++ b/test/e2e/simple.go @@ -49,7 +49,7 @@ func E2ESimple(logger *log.Logger) error { testnet.NoError("failed to read blockchain information", err) totalTxs := 0 - for _, blockMeta := range blockchain.BlockMetas { + for _, blockMeta := range blockchain { version := blockMeta.Header.Version.App if appconsts.LatestVersion != version { return fmt.Errorf("expected app version %d, got %d in blockMeta %d", appconsts.LatestVersion, version, blockMeta.Header.Height) diff --git a/test/util/testnode/read.go b/test/util/testnode/read.go index b85a1d9947..8cb018c92c 100644 --- a/test/util/testnode/read.go +++ b/test/util/testnode/read.go @@ -46,26 +46,41 @@ func ReadBlockchainInfo(ctx context.Context, rpcAddress string) ([]*types.BlockM if err != nil { return nil, err } + + // fetch the latest height resp, err := client.Status(ctx) if err != nil { return nil, err } + + // fetch the blocks meta data blocksMeta := make([]*types.BlockMeta, 0) - lastHeight := resp.SyncInfo.LatestBlockHeight - i := int64(0) + maxHeight := resp.SyncInfo.LatestBlockHeight + lastFetchedHeight := int64(0) + println("max height: ", maxHeight) for { - print("Reading blockchain info from height ", i, " to ", lastHeight, "\n") - res, err := client.BlockchainInfo(ctx, i, lastHeight) + // BlockchainInfo may not return the requested number of blocks (a limit of 20 may be applied), + // so we need to request them iteratively + println("fetching blocks from ", lastFetchedHeight+1, " to ", maxHeight) + res, err := client.BlockchainInfo(ctx, lastFetchedHeight+1, maxHeight) if err != nil { return nil, err } + blocksMeta = append(blocksMeta, res.BlockMetas...) - if res.LastHeight == 0 || res.LastHeight >= lastHeight { + println("fetched ", len(res.BlockMetas), " blocks") + + lastFetchedHeight = res.BlockMetas[len(res.BlockMetas)-1].Header.Height + println("last seen height: ", lastFetchedHeight) + + if lastFetchedHeight >= maxHeight { break } - i += res.LastHeight + } + println("Read ", len(blocksMeta), " blocks") + return blocksMeta, nil } From 22f6f1f48cd32d009433ca213b78aff1c40b7da2 Mon Sep 17 00:00:00 2001 From: sanaz Date: Thu, 11 Jul 2024 13:12:16 -0700 Subject: [PATCH 16/29] refactors the implementation --- test/e2e/benchmark/benchmark.go | 2 +- test/e2e/simple.go | 2 +- test/util/testnode/read.go | 27 ++++++++++++++++++++------- 3 files changed, 22 insertions(+), 9 deletions(-) diff --git a/test/e2e/benchmark/benchmark.go b/test/e2e/benchmark/benchmark.go index 39a2022e84..60dc90cbc5 100644 --- a/test/e2e/benchmark/benchmark.go +++ b/test/e2e/benchmark/benchmark.go @@ -149,7 +149,7 @@ func (b *BenchmarkTest) CheckResults(expectedBlockSizeBytes int64) error { } log.Println("Reading blockchain") - blockchain, err := testnode.ReadBlockchainInfo(context.Background(), + blockchain, err := testnode.ReadBlockchainHeaders(context.Background(), b.Node(0).AddressRPC()) testnet.NoError("failed to read blockchain information", err) diff --git a/test/e2e/simple.go b/test/e2e/simple.go index 2a148f3ddf..5d35d1bc52 100644 --- a/test/e2e/simple.go +++ b/test/e2e/simple.go @@ -45,7 +45,7 @@ func E2ESimple(logger *log.Logger) error { time.Sleep(30 * time.Second) logger.Println("Reading blockchain information") - blockchain, err := testnode.ReadBlockchainInfo(context.Background(), testNet.Node(0).AddressRPC()) + blockchain, err := testnode.ReadBlockchainHeaders(context.Background(), testNet.Node(0).AddressRPC()) testnet.NoError("failed to read blockchain information", err) totalTxs := 0 diff --git a/test/util/testnode/read.go b/test/util/testnode/read.go index 8cb018c92c..9e5cc771e4 100644 --- a/test/util/testnode/read.go +++ b/test/util/testnode/read.go @@ -39,9 +39,9 @@ func ReadBlockchain(ctx context.Context, rpcAddress string) ([]*types.Block, err return ReadBlockHeights(ctx, rpcAddress, 1, status.SyncInfo.LatestBlockHeight) } -// ReadBlockchainInfo retrieves the blockchain information from height 0 up to the latest height from the node at -// rpcAddress and returns it. -func ReadBlockchainInfo(ctx context.Context, rpcAddress string) ([]*types.BlockMeta, error) { +// ReadBlockchainHeaders retrieves the blockchain headers from height 0 up to +// latest available height from the node at rpcAddress and returns it. +func ReadBlockchainHeaders(ctx context.Context, rpcAddress string) ([]*types.BlockMeta, error) { client, err := http.New(rpcAddress, "/websocket") if err != nil { return nil, err @@ -55,14 +55,16 @@ func ReadBlockchainInfo(ctx context.Context, rpcAddress string) ([]*types.BlockM // fetch the blocks meta data blocksMeta := make([]*types.BlockMeta, 0) + // fetch headers up to maxHeight maxHeight := resp.SyncInfo.LatestBlockHeight lastFetchedHeight := int64(0) println("max height: ", maxHeight) for { - // BlockchainInfo may not return the requested number of blocks (a limit of 20 may be applied), + // BlockchainInfo applies a limit of 20 may on the range of blocks to fetch // so we need to request them iteratively - println("fetching blocks from ", lastFetchedHeight+1, " to ", maxHeight) - res, err := client.BlockchainInfo(ctx, lastFetchedHeight+1, maxHeight) + println("fetching blocks from ", 1, " to ", maxHeight) + // Block headers are returned in descending order (highest first). + res, err := client.BlockchainInfo(ctx, 1, maxHeight) if err != nil { return nil, err } @@ -73,17 +75,28 @@ func ReadBlockchainInfo(ctx context.Context, rpcAddress string) ([]*types.BlockM lastFetchedHeight = res.BlockMetas[len(res.BlockMetas)-1].Header.Height println("last seen height: ", lastFetchedHeight) - if lastFetchedHeight >= maxHeight { + // fetch until the first block + if lastFetchedHeight <= 1 { break } + maxHeight = lastFetchedHeight - 1 } println("Read ", len(blocksMeta), " blocks") + // Block headers are returned in descending order (highest first). We need to reverse the order + reverseSlice(blocksMeta) + + println(blocksMeta[0].Header.Height, blocksMeta[len(blocksMeta)-1].Header.Height) return blocksMeta, nil } +func reverseSlice[T any](s []T) { + for i, j := 0, len(s)-1; i < j; i, j = i+1, j-1 { + s[i], s[j] = s[j], s[i] + } +} func ReadBlockHeights(ctx context.Context, rpcAddress string, fromHeight, toHeight int64) ([]*types.Block, error) { client, err := http.New(rpcAddress, "/websocket") if err != nil { From 0901d092b1ff8108b807101becbf71420c5958d7 Mon Sep 17 00:00:00 2001 From: sanaz Date: Thu, 11 Jul 2024 14:05:10 -0700 Subject: [PATCH 17/29] swaps info with headers --- test/e2e/benchmark/benchmark.go | 4 ++-- test/e2e/simple.go | 4 ++-- test/util/testnode/read.go | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/test/e2e/benchmark/benchmark.go b/test/e2e/benchmark/benchmark.go index 60dc90cbc5..b4e2330f33 100644 --- a/test/e2e/benchmark/benchmark.go +++ b/test/e2e/benchmark/benchmark.go @@ -148,10 +148,10 @@ func (b *BenchmarkTest) CheckResults(expectedBlockSizeBytes int64) error { } } - log.Println("Reading blockchain") + log.Println("Reading blockchain headers") blockchain, err := testnode.ReadBlockchainHeaders(context.Background(), b.Node(0).AddressRPC()) - testnet.NoError("failed to read blockchain information", err) + testnet.NoError("failed to read blockchain headers", err) targetSizeReached := false maxBlockSize := int64(0) diff --git a/test/e2e/simple.go b/test/e2e/simple.go index 5d35d1bc52..3ad14f604f 100644 --- a/test/e2e/simple.go +++ b/test/e2e/simple.go @@ -44,9 +44,9 @@ func E2ESimple(logger *log.Logger) error { // wait for 30 seconds time.Sleep(30 * time.Second) - logger.Println("Reading blockchain information") + logger.Println("Reading blockchain headers") blockchain, err := testnode.ReadBlockchainHeaders(context.Background(), testNet.Node(0).AddressRPC()) - testnet.NoError("failed to read blockchain information", err) + testnet.NoError("failed to read blockchain headers", err) totalTxs := 0 for _, blockMeta := range blockchain { diff --git a/test/util/testnode/read.go b/test/util/testnode/read.go index 9e5cc771e4..0c470d3edd 100644 --- a/test/util/testnode/read.go +++ b/test/util/testnode/read.go @@ -53,7 +53,7 @@ func ReadBlockchainHeaders(ctx context.Context, rpcAddress string) ([]*types.Blo return nil, err } - // fetch the blocks meta data + // fetch the blocks metadata/headers blocksMeta := make([]*types.BlockMeta, 0) // fetch headers up to maxHeight maxHeight := resp.SyncInfo.LatestBlockHeight From c7bede76c7ebc0be2e46293c2188382decfeed08 Mon Sep 17 00:00:00 2001 From: sanaz Date: Thu, 11 Jul 2024 14:13:48 -0700 Subject: [PATCH 18/29] minor doc fix --- test/util/testnode/read.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/util/testnode/read.go b/test/util/testnode/read.go index 0c470d3edd..457096409e 100644 --- a/test/util/testnode/read.go +++ b/test/util/testnode/read.go @@ -60,10 +60,10 @@ func ReadBlockchainHeaders(ctx context.Context, rpcAddress string) ([]*types.Blo lastFetchedHeight := int64(0) println("max height: ", maxHeight) for { - // BlockchainInfo applies a limit of 20 may on the range of blocks to fetch - // so we need to request them iteratively + // BlockchainInfo may apply on the range of blocks to fetch, + // so we need to request them iteratively. println("fetching blocks from ", 1, " to ", maxHeight) - // Block headers are returned in descending order (highest first). + // block headers are returned in descending order (highest first). res, err := client.BlockchainInfo(ctx, 1, maxHeight) if err != nil { return nil, err From 070101efc27820a43be90a9678165b03e0829401 Mon Sep 17 00:00:00 2001 From: sanaz Date: Thu, 11 Jul 2024 14:24:23 -0700 Subject: [PATCH 19/29] deletes print statements --- test/util/testnode/read.go | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/test/util/testnode/read.go b/test/util/testnode/read.go index 457096409e..b90670fbb2 100644 --- a/test/util/testnode/read.go +++ b/test/util/testnode/read.go @@ -41,6 +41,7 @@ func ReadBlockchain(ctx context.Context, rpcAddress string) ([]*types.Block, err // ReadBlockchainHeaders retrieves the blockchain headers from height 0 up to // latest available height from the node at rpcAddress and returns it. +// The headers are returned in ascending order (lowest first). func ReadBlockchainHeaders(ctx context.Context, rpcAddress string) ([]*types.BlockMeta, error) { client, err := http.New(rpcAddress, "/websocket") if err != nil { @@ -62,7 +63,6 @@ func ReadBlockchainHeaders(ctx context.Context, rpcAddress string) ([]*types.Blo for { // BlockchainInfo may apply on the range of blocks to fetch, // so we need to request them iteratively. - println("fetching blocks from ", 1, " to ", maxHeight) // block headers are returned in descending order (highest first). res, err := client.BlockchainInfo(ctx, 1, maxHeight) if err != nil { @@ -70,10 +70,8 @@ func ReadBlockchainHeaders(ctx context.Context, rpcAddress string) ([]*types.Blo } blocksMeta = append(blocksMeta, res.BlockMetas...) - println("fetched ", len(res.BlockMetas), " blocks") lastFetchedHeight = res.BlockMetas[len(res.BlockMetas)-1].Header.Height - println("last seen height: ", lastFetchedHeight) // fetch until the first block if lastFetchedHeight <= 1 { @@ -83,15 +81,14 @@ func ReadBlockchainHeaders(ctx context.Context, rpcAddress string) ([]*types.Blo } - println("Read ", len(blocksMeta), " blocks") - // Block headers are returned in descending order (highest first). We need to reverse the order + // blocksMeta is in descending order (highest first). + // We need to reverse the order. reverseSlice(blocksMeta) - - println(blocksMeta[0].Header.Height, blocksMeta[len(blocksMeta)-1].Header.Height) - + return blocksMeta, nil } +// reverseSlice reverses the order of elements in a slice in place. func reverseSlice[T any](s []T) { for i, j := 0, len(s)-1; i < j; i, j = i+1, j-1 { s[i], s[j] = s[j], s[i] From b52cb0870064289e724fe295be3c57dd8ebc66f9 Mon Sep 17 00:00:00 2001 From: sanaz Date: Thu, 11 Jul 2024 16:14:54 -0700 Subject: [PATCH 20/29] retracts old waiting values --- test/e2e/testnet/testnet.go | 6 +++--- test/util/testnode/read.go | 3 ++- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/test/e2e/testnet/testnet.go b/test/e2e/testnet/testnet.go index b0f500d8eb..328cd5c6a9 100644 --- a/test/e2e/testnet/testnet.go +++ b/test/e2e/testnet/testnet.go @@ -356,10 +356,10 @@ func (t *Testnet) Start() error { if err != nil { return fmt.Errorf("failed to initialized node %s: %w", node.Name, err) } - for i := 0; i < 20; i++ { + for i := 0; i < 10; i++ { resp, err := client.Status(context.Background()) if err != nil { - if i == 19 { + if i == 9 { return fmt.Errorf("node %s status response: %w", node.Name, err) } time.Sleep(time.Second) @@ -372,7 +372,7 @@ func (t *Testnet) Start() error { } log.Info().Int64("height", resp.SyncInfo.LatestBlockHeight).Msg( "height is 0, waiting...") - if i == 19 { + if i == 10 { return fmt.Errorf("failed to start node %s", node.Name) } fmt.Printf("node %s is not synced yet, waiting...\n", node.Name) diff --git a/test/util/testnode/read.go b/test/util/testnode/read.go index b90670fbb2..9f9a26da4f 100644 --- a/test/util/testnode/read.go +++ b/test/util/testnode/read.go @@ -84,7 +84,7 @@ func ReadBlockchainHeaders(ctx context.Context, rpcAddress string) ([]*types.Blo // blocksMeta is in descending order (highest first). // We need to reverse the order. reverseSlice(blocksMeta) - + return blocksMeta, nil } @@ -94,6 +94,7 @@ func reverseSlice[T any](s []T) { s[i], s[j] = s[j], s[i] } } + func ReadBlockHeights(ctx context.Context, rpcAddress string, fromHeight, toHeight int64) ([]*types.Block, error) { client, err := http.New(rpcAddress, "/websocket") if err != nil { From 8ae64a3fe7c116f8ee6e7653ea37ce26b493d5e1 Mon Sep 17 00:00:00 2001 From: sanaz Date: Thu, 11 Jul 2024 16:16:08 -0700 Subject: [PATCH 21/29] fix a bug --- test/e2e/testnet/testnet.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e/testnet/testnet.go b/test/e2e/testnet/testnet.go index 328cd5c6a9..e300a77288 100644 --- a/test/e2e/testnet/testnet.go +++ b/test/e2e/testnet/testnet.go @@ -372,7 +372,7 @@ func (t *Testnet) Start() error { } log.Info().Int64("height", resp.SyncInfo.LatestBlockHeight).Msg( "height is 0, waiting...") - if i == 10 { + if i == 9 { return fmt.Errorf("failed to start node %s", node.Name) } fmt.Printf("node %s is not synced yet, waiting...\n", node.Name) From c89ac2c967cd38a865f5f9697419461c872115fc Mon Sep 17 00:00:00 2001 From: sanaz Date: Thu, 11 Jul 2024 16:23:01 -0700 Subject: [PATCH 22/29] updates some of the comments for clarity --- test/util/testnode/read.go | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/test/util/testnode/read.go b/test/util/testnode/read.go index 9f9a26da4f..c86835f2b7 100644 --- a/test/util/testnode/read.go +++ b/test/util/testnode/read.go @@ -39,7 +39,7 @@ func ReadBlockchain(ctx context.Context, rpcAddress string) ([]*types.Block, err return ReadBlockHeights(ctx, rpcAddress, 1, status.SyncInfo.LatestBlockHeight) } -// ReadBlockchainHeaders retrieves the blockchain headers from height 0 up to +// ReadBlockchainHeaders retrieves the blockchain headers from height 1 up to // latest available height from the node at rpcAddress and returns it. // The headers are returned in ascending order (lowest first). func ReadBlockchainHeaders(ctx context.Context, rpcAddress string) ([]*types.BlockMeta, error) { @@ -53,23 +53,23 @@ func ReadBlockchainHeaders(ctx context.Context, rpcAddress string) ([]*types.Blo if err != nil { return nil, err } + maxHeight := resp.SyncInfo.LatestBlockHeight - // fetch the blocks metadata/headers - blocksMeta := make([]*types.BlockMeta, 0) + blockHeaders := make([]*types.BlockMeta, 0) // fetch headers up to maxHeight - maxHeight := resp.SyncInfo.LatestBlockHeight lastFetchedHeight := int64(0) println("max height: ", maxHeight) for { - // BlockchainInfo may apply on the range of blocks to fetch, + // BlockchainInfo may apply a limit on the range of blocks to fetch, // so we need to request them iteratively. - // block headers are returned in descending order (highest first). + // note that block headers returned by BlockchainInfo are in descending + // order (highest first). res, err := client.BlockchainInfo(ctx, 1, maxHeight) if err != nil { return nil, err } - blocksMeta = append(blocksMeta, res.BlockMetas...) + blockHeaders = append(blockHeaders, res.BlockMetas...) lastFetchedHeight = res.BlockMetas[len(res.BlockMetas)-1].Header.Height @@ -77,15 +77,16 @@ func ReadBlockchainHeaders(ctx context.Context, rpcAddress string) ([]*types.Blo if lastFetchedHeight <= 1 { break } + + // set the new maxHeight to fetch the next batch of headers maxHeight = lastFetchedHeight - 1 } - // blocksMeta is in descending order (highest first). - // We need to reverse the order. - reverseSlice(blocksMeta) + // reverse the order of headers to be ascending (lowest first). + reverseSlice(blockHeaders) - return blocksMeta, nil + return blockHeaders, nil } // reverseSlice reverses the order of elements in a slice in place. From 9be60489851a73e12a386d777f9be13ee7f20acb Mon Sep 17 00:00:00 2001 From: sanaz Date: Thu, 11 Jul 2024 16:39:41 -0700 Subject: [PATCH 23/29] adds network test with latency and 8 MB block size --- test/e2e/benchmark/main.go | 1 + test/e2e/benchmark/throughput.go | 12 +++++++++++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/test/e2e/benchmark/main.go b/test/e2e/benchmark/main.go index 00bcaec154..bc2c19cf30 100644 --- a/test/e2e/benchmark/main.go +++ b/test/e2e/benchmark/main.go @@ -19,6 +19,7 @@ func main() { {"LargeNetworkBigBlock32MB", LargeNetworkBigBlock32MB}, {"LargeNetworkBigBlock64MB", LargeNetworkBigBlock64MB}, {"LargeNetworkBigBlock64MBLatency", LargeNetworkBigBlock64MBLatency}, + {"LargeNetworkBigBlock8MBLatency", LargeNetworkBigBlock8MBLatency}, } // check the test name passed as an argument and run it diff --git a/test/e2e/benchmark/throughput.go b/test/e2e/benchmark/throughput.go index 20388e2410..096db9ea9d 100644 --- a/test/e2e/benchmark/throughput.go +++ b/test/e2e/benchmark/throughput.go @@ -188,5 +188,15 @@ func LargeNetworkBigBlock64MBLatency(logger *log.Logger) error { manifest.BlobSequences = 2 manifest.EnableLatency = true manifest.LatencyParams = LatencyParams{70, 0} - return runBenchmarkTest(logger, "LargeNetworkBigBlock64MB", manifest) + return runBenchmarkTest(logger, "LargeNetworkBigBlock64MBLatency", manifest) +} +func LargeNetworkBigBlock8MBLatency(logger *log.Logger) error { + manifest := bigBlockManifest + manifest.MaxBlockBytes = 8 * testnet.MB + manifest.Validators = 50 + manifest.TxClients = 50 + manifest.BlobSequences = 2 + manifest.EnableLatency = true + manifest.LatencyParams = LatencyParams{70, 0} + return runBenchmarkTest(logger, "LargeNetworkBigBlock8MBLatency", manifest) } From 074bea10616fe9895d4354f2934796fb63353e67 Mon Sep 17 00:00:00 2001 From: sanaz Date: Thu, 11 Jul 2024 16:39:57 -0700 Subject: [PATCH 24/29] extends wait time for genesis nodes to sync --- test/e2e/testnet/testnet.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/e2e/testnet/testnet.go b/test/e2e/testnet/testnet.go index e300a77288..28858f2a8e 100644 --- a/test/e2e/testnet/testnet.go +++ b/test/e2e/testnet/testnet.go @@ -356,10 +356,10 @@ func (t *Testnet) Start() error { if err != nil { return fmt.Errorf("failed to initialized node %s: %w", node.Name, err) } - for i := 0; i < 10; i++ { + for i := 0; i < 100; i++ { resp, err := client.Status(context.Background()) if err != nil { - if i == 9 { + if i == 99 { return fmt.Errorf("node %s status response: %w", node.Name, err) } time.Sleep(time.Second) @@ -372,7 +372,7 @@ func (t *Testnet) Start() error { } log.Info().Int64("height", resp.SyncInfo.LatestBlockHeight).Msg( "height is 0, waiting...") - if i == 9 { + if i == 99 { return fmt.Errorf("failed to start node %s", node.Name) } fmt.Printf("node %s is not synced yet, waiting...\n", node.Name) From c925179cbbc08026fa05256ff8ea967604493126 Mon Sep 17 00:00:00 2001 From: sanaz Date: Fri, 12 Jul 2024 09:12:02 -0700 Subject: [PATCH 25/29] adds a prefix --- test/e2e/benchmark/throughput.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e/benchmark/throughput.go b/test/e2e/benchmark/throughput.go index 096db9ea9d..ec55d6d353 100644 --- a/test/e2e/benchmark/throughput.go +++ b/test/e2e/benchmark/throughput.go @@ -109,7 +109,7 @@ func TwoNodeSimple(logger *log.Logger) error { func runBenchmarkTest(logger *log.Logger, testName string, manifest Manifest) error { logger.Println("Running", testName) - manifest.ChainID = manifest.summary() + manifest.ChainID = "second-" + manifest.summary() log.Println("ChainID: ", manifest.ChainID) benchTest, err := NewBenchmarkTest(testName, &manifest) testnet.NoError("failed to create benchmark test", err) From 222d45d3326503e0a04976bfd90e366a42940949 Mon Sep 17 00:00:00 2001 From: sanaz Date: Fri, 12 Jul 2024 10:26:14 -0700 Subject: [PATCH 26/29] extends test duration --- test/e2e/benchmark/throughput.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/e2e/benchmark/throughput.go b/test/e2e/benchmark/throughput.go index ec55d6d353..4aaf457205 100644 --- a/test/e2e/benchmark/throughput.go +++ b/test/e2e/benchmark/throughput.go @@ -109,7 +109,7 @@ func TwoNodeSimple(logger *log.Logger) error { func runBenchmarkTest(logger *log.Logger, testName string, manifest Manifest) error { logger.Println("Running", testName) - manifest.ChainID = "second-" + manifest.summary() + manifest.ChainID = "third-" + manifest.summary() log.Println("ChainID: ", manifest.ChainID) benchTest, err := NewBenchmarkTest(testName, &manifest) testnet.NoError("failed to create benchmark test", err) @@ -198,5 +198,6 @@ func LargeNetworkBigBlock8MBLatency(logger *log.Logger) error { manifest.BlobSequences = 2 manifest.EnableLatency = true manifest.LatencyParams = LatencyParams{70, 0} + manifest.TestDuration = 10 * time.Minute return runBenchmarkTest(logger, "LargeNetworkBigBlock8MBLatency", manifest) } From af001b27e0cb3ee129377bcdb1d828f9211f9d0e Mon Sep 17 00:00:00 2001 From: sanaz Date: Fri, 12 Jul 2024 11:29:22 -0700 Subject: [PATCH 27/29] reduces sequences to 1 --- test/e2e/benchmark/throughput.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/e2e/benchmark/throughput.go b/test/e2e/benchmark/throughput.go index 4aaf457205..3f92b6ab22 100644 --- a/test/e2e/benchmark/throughput.go +++ b/test/e2e/benchmark/throughput.go @@ -109,7 +109,7 @@ func TwoNodeSimple(logger *log.Logger) error { func runBenchmarkTest(logger *log.Logger, testName string, manifest Manifest) error { logger.Println("Running", testName) - manifest.ChainID = "third-" + manifest.summary() + manifest.ChainID = manifest.summary() log.Println("ChainID: ", manifest.ChainID) benchTest, err := NewBenchmarkTest(testName, &manifest) testnet.NoError("failed to create benchmark test", err) @@ -195,9 +195,9 @@ func LargeNetworkBigBlock8MBLatency(logger *log.Logger) error { manifest.MaxBlockBytes = 8 * testnet.MB manifest.Validators = 50 manifest.TxClients = 50 - manifest.BlobSequences = 2 + manifest.BlobSequences = 1 manifest.EnableLatency = true manifest.LatencyParams = LatencyParams{70, 0} - manifest.TestDuration = 10 * time.Minute + //manifest.TestDuration = 10 * time.Minute return runBenchmarkTest(logger, "LargeNetworkBigBlock8MBLatency", manifest) } From 74977145e703cab72c3d1fa1aa3192fb4b4ca015 Mon Sep 17 00:00:00 2001 From: sanaz Date: Fri, 12 Jul 2024 12:04:18 -0700 Subject: [PATCH 28/29] manifest of next experiment --- test/e2e/benchmark/throughput.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/e2e/benchmark/throughput.go b/test/e2e/benchmark/throughput.go index 3f92b6ab22..87de5c9419 100644 --- a/test/e2e/benchmark/throughput.go +++ b/test/e2e/benchmark/throughput.go @@ -109,7 +109,7 @@ func TwoNodeSimple(logger *log.Logger) error { func runBenchmarkTest(logger *log.Logger, testName string, manifest Manifest) error { logger.Println("Running", testName) - manifest.ChainID = manifest.summary() + manifest.ChainID = "fifth" + manifest.summary() log.Println("ChainID: ", manifest.ChainID) benchTest, err := NewBenchmarkTest(testName, &manifest) testnet.NoError("failed to create benchmark test", err) @@ -195,9 +195,9 @@ func LargeNetworkBigBlock8MBLatency(logger *log.Logger) error { manifest.MaxBlockBytes = 8 * testnet.MB manifest.Validators = 50 manifest.TxClients = 50 - manifest.BlobSequences = 1 + manifest.BlobSequences = 2 manifest.EnableLatency = true manifest.LatencyParams = LatencyParams{70, 0} - //manifest.TestDuration = 10 * time.Minute + manifest.TestDuration = 10 * time.Minute return runBenchmarkTest(logger, "LargeNetworkBigBlock8MBLatency", manifest) } From 7170731e9b2db35f783d65a01a574693bb219dd2 Mon Sep 17 00:00:00 2001 From: Sanaz Taheri <35961250+staheri14@users.noreply.github.com> Date: Wed, 21 Aug 2024 16:25:40 -0700 Subject: [PATCH 29/29] sets volume to 1Gi --- test/e2e/testnet/defaults.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e/testnet/defaults.go b/test/e2e/testnet/defaults.go index 754a1bf8b5..1ea4bbb585 100644 --- a/test/e2e/testnet/defaults.go +++ b/test/e2e/testnet/defaults.go @@ -4,7 +4,7 @@ var DefaultResources = Resources{ MemoryRequest: "400Mi", MemoryLimit: "400Mi", CPU: "300m", - Volume: "0Gi", + Volume: "1Gi", } const (