Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

Consolidate the confirms under the same struct #311

Open
rach-id opened this issue Apr 25, 2023 · 0 comments
Open

Consolidate the confirms under the same struct #311

rach-id opened this issue Apr 25, 2023 · 0 comments
Labels
p2p p2p network related

Comments

@rach-id
Copy link
Member

rach-id commented Apr 25, 2023

Currently, the ValsetConfirm and DataCommitmentConfirm structs are the same:

type DataCommitmentConfirm struct {
// Signature over the commitment, the range of blocks, the validator address
// and the Ethereum address.
Signature string
// Hex `0x` encoded Ethereum public key that will be used by this validator on
// Ethereum.
EthAddress string
}

type ValsetConfirm struct {
// Ethereum address, associated to the orchestrator, used to sign the `ValSet`
// message.
EthAddress string
// The `ValSet` message signature.
Signature string
}

We could look into consolidating them into the same struct.

@rach-id rach-id added the p2p p2p network related label Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p2p p2p network related
Projects
None yet
Development

No branches or pull requests

1 participant