Redundant EthAdress in ValsetConfirm

[dalmirel]

Involved artifacts

• types/valset_confirm.go
• orchestrator/broadcaster.go
• relayer/relayer.go

Description

During the analysis of update validator set flow, it was noticed that EthAddress was stored two times for one entry when:

• when orchestrator is placing the ValsetConfirm for attestation in the qgbDHT store
• when relayer is placing the ValsetConfirms in the SignatureStore

Problem Scenarios

The suggestions mentioned earlier can help save memory if the EthAddress field is not utilized in ValsetConfirm.

Recommendation

We suggest simplifying the stored values if possible and reconstructing the ValsetConfirms if needed, upon reading the values from the store. In our analysis throughout this project, we did not identify any instances where theValsetConfirm's EthAddress field was used.
However, it's important to note that a detailed audit of the relayer and orchestrator code has not been conducted, so we cannot definitively assert this to be the case.