You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.
thanks for helping me figure this out and thinking about this before hand but tbc this is not blocking this PR (hence the approve)
I'm still of the opinion that the default should work without requiring the use and knowledge of a flag. So either we enable self signing by default on the server side, or by default we enable insecure connections on the client side. Having something that doesn't work by default is something that should be avoided imo
That depends on the queries. If the query requires a gRPC connection, then the TLS is enabled by default. If the request is only targeting RPC, then there is no TLS for that.
yeah I get that part
I've always assumed that this uses grpc under the hood by swapping the port and protocol, then using insecure as a default. In reality I think this is just making an ABCI Query over rest. Either that or the gateway mapping is being used, as this works as expected
I'm still of the opinion that the default should work without requiring the use and knowledge of a flag. So either we enable self signing by default on the server side, or by default we enable insecure connections on the client side. Having something that doesn't work by default is something that should be avoided imo
yeah I get that part
I've always assumed that this uses grpc under the hood by swapping the port and protocol, then using insecure as a default. In reality I think this is just making an ABCI Query over rest. Either that or the gateway mapping is being used, as this works as expected
Originally posted by @evan-forbes in #592 (comment)
The text was updated successfully, but these errors were encountered: